<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Dec 3, 2013 at 7:38 PM, Bruce Ashfield <span dir="ltr"><<a href="mailto:bruce.ashfield@windriver.com" target="_blank">bruce.ashfield@windriver.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb adM"><div class="h5">On 12/3/2013, 5:40 PM, Richard Purdie wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On Tue, 2013-12-03 at 11:40 -0700, Chris Larson wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On Wed, Nov 27, 2013 at 11:07 AM, Christopher Larson<br>
<<a href="mailto:kergoth@gmail.com" target="_blank">kergoth@gmail.com</a>> wrote:<br>
The following changes since commit<br>
f991d2d60b74f5ebd990f77aecd332<u></u>4b1a4533e9:<br>
<br>
libpng: set reasonable SUMMARY (2013-11-27 11:51:08 +0000)<br>
<br>
are available in the git repository at:<br>
<br>
<a href="https://github.com/kergoth/oe-core.git" target="_blank">https://github.com/kergoth/oe-<u></u>core.git</a> random-fixes<br>
<a href="https://github.com/kergoth/oe-core/tree/random-fixes" target="_blank">https://github.com/kergoth/oe-<u></u>core/tree/random-fixes</a><br>
<br>
Christopher Larson (7):<br>
update-rc.d: process symlinks recursively<br>
perf: remove /usr/local/include from default makefile<br>
includes<br>
pulseaudio: fix RDEPENDS traversal for consolekit<br>
<br>
Were there issues with these, or was it just that further testing was<br>
necessary? I noticed this series was partially applied.<br>
</blockquote>
<br>
On the most part just being cautious for M1.<br>
<br>
The perf one does worry me as we keep going around in circles on it<br>
where we change one thing, it breaks something else, we fix that,<br>
something else breaks, we fix that and we end up back where we started.<br>
The commit history and/or the mailing list should have details about<br>
what happened there. CC'ing Bruce since I know he has opinions on the<br>
perf fix. Bruce, did we get a fix for that upstream in the end?<br>
</blockquote>
<br></div></div>
My favourite topic. I'm working on the upstream fix, which was that we<br>
shouldn't be using CFLAGS and LDFLAGS to pass build values into perf,<br>
but instead use EXTRA_CLFAGS (which exists) and EXTRA_LDFLAGS (Which<br>
doesn't exist yet, and that's the patch I have queued).<br>
<br>
Looking at Chris' posted patch, I can't actually tell what it was fixing, since INCLUDES isn't directly used by the perf Makefiles and on<br>
a really quick check, I can't see what CONFIG_INCLUDES is set to either.<br>
<br>
I'm sure I'm just being dense (long day) and I'm missing something, so<br>
I can't map the short log's intent to what the patch is actually doing.<br>
<br>
The patch won't undo anything that we are working to fix/change<br>
upstream, but since something is whizzing over my head, I can't be sure<br>
about side effects.</blockquote></div><br>*shrug*, it’s possible it was to fix warnings only with older kernels, as we use our own BSPs in some cases. I’m not opposed to you dropping that patch, it was only a warning fix for us anyway :)<br>
-- <br>Christopher Larson<br>clarson at kergoth dot com<br>Founder - BitBake, OpenEmbedded, OpenZaurus<br>Maintainer - Tslib<br>Senior Software Engineer, Mentor Graphics
</div></div>