<div dir="ltr"><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Dec 5, 2013 at 9:25 PM, Saul Wold <span dir="ltr"><<a href="mailto:sgw@linux.intel.com" target="_blank">sgw@linux.intel.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
Andrei:<br>
<br>
I see RP already merged this, but I have a couple of comments<div class="im"><br>
<br>
<br>
On 12/05/2013 01:01 AM, Andrei Gherzan wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Signed-off-by: Andrei Gherzan <<a href="mailto:andrei@gherzan.ro" target="_blank">andrei@gherzan.ro</a>><br>
---<br>
.../0001-configure-enable-pic-<u></u>for-AArch64.patch | 0<br>
meta/recipes-multimedia/libav/<u></u>{<a href="http://libav_0.8.8.bb" target="_blank">libav_0.8.8.bb</a> => <a href="http://libav_0.8.9.bb" target="_blank">libav_0.8.9.bb</a>} | 8 +++-----<br>
2 files changed, 3 insertions(+), 5 deletions(-)<br>
rename meta/recipes-multimedia/libav/<u></u>{libav-0.8.8 => libav-0.8.9}/0001-configure-<u></u>enable-pic-for-AArch64.patch (100%)<br>
rename meta/recipes-multimedia/libav/<u></u>{<a href="http://libav_0.8.8.bb" target="_blank">libav_0.8.8.bb</a> => <a href="http://libav_0.8.9.bb" target="_blank">libav_0.8.9.bb</a>} (69%)<br>
<br>
diff --git a/meta/recipes-multimedia/<u></u>libav/libav-0.8.8/0001-<u></u>configure-enable-pic-for-<u></u>AArch64.patch b/meta/recipes-multimedia/<u></u>libav/libav-0.8.9/0001-<u></u>configure-enable-pic-for-<u></u>AArch64.patch<br>
similarity index 100%<br>
rename from meta/recipes-multimedia/libav/<u></u>libav-0.8.8/0001-configure-<u></u>enable-pic-for-AArch64.patch<br>
rename to meta/recipes-multimedia/libav/<u></u>libav-0.8.9/0001-configure-<u></u>enable-pic-for-AArch64.patch<br>
</blockquote>
<br></div>
We are generally trying to get rid of versioned patch directory in favor of just a general recipe name (libav in this case).<div class="im"><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
diff --git a/meta/recipes-multimedia/<u></u>libav/<a href="http://libav_0.8.8.bb" target="_blank">libav_0.8.8.bb</a> b/meta/recipes-multimedia/<u></u>libav/<a href="http://libav_0.8.9.bb" target="_blank">libav_0.8.9.bb</a><br>
similarity index 69%<br>
rename from meta/recipes-multimedia/libav/<a href="http://libav_0.8.8.bb" target="_blank"><u></u>libav_0.8.8.bb</a><br>
rename to meta/recipes-multimedia/libav/<a href="http://libav_0.8.9.bb" target="_blank"><u></u>libav_0.8.9.bb</a><br>
index 9cb4cf2..065a6d2 100644<br>
--- a/meta/recipes-multimedia/<u></u>libav/<a href="http://libav_0.8.8.bb" target="_blank">libav_0.8.8.bb</a><br>
+++ b/meta/recipes-multimedia/<u></u>libav/<a href="http://libav_0.8.9.bb" target="_blank">libav_0.8.9.bb</a><br>
@@ -1,10 +1,10 @@<br>
require libav.inc<br>
<br>
-SRC_URI = "<a href="http://libav.org/releases/libav-0.8.8.tar.xz" target="_blank">http://libav.org/releases/<u></u>libav-0.8.8.tar.xz</a> \<br>
+SRC_URI = "<a href="http://libav.org/releases/libav-0.8.9.tar.xz" target="_blank">http://libav.org/releases/<u></u>libav-0.8.9.tar.xz</a> \<br>
</blockquote></div>
why not convert this to ${BP} so it does not need to be edited in the future. BP = BPN-PV.<br>
<br>
Sau!</blockquote></div><br>Pushing a patch to address these comments. Thanks.</div><div class="gmail_extra"><div><br></div>-- </div><div class="gmail_extra"><b style="text-align:center;color:rgb(51,51,51);font-family:Arial">ag</b>
</div></div>