<div dir="ltr">Just a heads-up, this is a stand-alone patch, not a series, despite the subject line :(<div><br></div><div>Alex</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Dec 18, 2013 at 7:24 PM, Alex DAMIAN <span dir="ltr"><<a href="mailto:alexandru.damian@intel.com" target="_blank">alexandru.damian@intel.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Alexandru DAMIAN <<a href="mailto:alexandru.damian@intel.com">alexandru.damian@intel.com</a>><br>
<br>
Toaster needs buildstats to be enabled in order to<br>
collect task statistics. The toaster.bbclass didn't<br>
have a guard to stop task data collection if the buildstats<br>
weren't enabled, leading to a crash.<br>
<br>
This patch verifies that the task variables are defined before<br>
trying to use them.<br>
<br>
Signed-off-by: Alexandru DAMIAN <<a href="mailto:alexandru.damian@intel.com">alexandru.damian@intel.com</a>><br>
---<br>
meta/classes/toaster.bbclass | 3 +++<br>
1 file changed, 3 insertions(+)<br>
<br>
diff --git a/meta/classes/toaster.bbclass b/meta/classes/toaster.bbclass<br>
index e1a93b5..08c7bfa 100644<br>
--- a/meta/classes/toaster.bbclass<br>
+++ b/meta/classes/toaster.bbclass<br>
@@ -165,6 +165,9 @@ python toaster_collect_task_stats() {<br>
import bb.utils<br>
import os<br>
<br>
+ if None == e.data.getVar('BUILDSTATS_BASE', True):<br>
+ return # if we don't have buildstats, we cannot collect stats<br>
+<br>
def _append_read_list(v):<br>
lock = bb.utils.lockfile(e.data.expand("${TOPDIR}/toaster.lock"), False, True)<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
1.8.3.2<br>
<br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">Alex Damian<div>Yocto Project<br></div><div>SSG / OTC </div></div>
</div>