<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 01/06/2014 08:25 PM, Richard Purdie
wrote:<br>
</div>
<blockquote cite="mid:1389011136.22784.7.camel@ted" type="cite">
<pre wrap="">On Thu, 2013-11-14 at 18:51 +0800, Ming Liu wrote:
</pre>
<blockquote type="cite">
<pre wrap="">This patch mainly aims to add optimisation for crosssdk setscene dependency
validating which we haven't handled in current logic, and which I think we
could have as we've already implemented to native/cross, although there
are albeit not many crossdk tasks, we could still get some performance
enhancement.
And it also fix a vulnerability of some certain workflow, think about the
following scenario with current logic:
bitbake nativesdk-eglibc-initial -c cleansstate
bitbake gcc-crosssdk-initial -c clean
bitbake gmp-native -c clean
bitbake libmpc-native -c clean
bitbake mpfr-native -c clean
bitbake gcc-crosssdk-initial
bitbake nativesdk-eglibc-initial
Aboving will fail for absence of a few native libraries required by
gcc-crosssdk-initial.
Also modified some places in current code except the optimisation, as
following:
1 Remove isNative function since no code is referring it.
2 Add do_package to the list that don't exist and are noexec.
</pre>
</blockquote>
<pre wrap="">
I've split this patch up as its doing too many things at once. In
particular, I think we should keep the "isNativeCross()" function name
instead of adding Crosssdk to the name since it just makes things more
confusing to read.</pre>
</blockquote>
I am on board with your comments.<br>
<br>
<blockquote cite="mid:1389011136.22784.7.camel@ted" type="cite">
<pre wrap="">
I've take a part for the crosssdk part in master-next which is being
tested at the moment, can you resent the do_package part by itself
please?</pre>
</blockquote>
No problem, I will resend a patch soon with modifying the do_package
part only.<br>
<br>
<blockquote cite="mid:1389011136.22784.7.camel@ted" type="cite">
<pre wrap="">
I don't quite understand how the sequence of commands above breaks
things or how this patch fixes it. Are you sure this wasn't fixed by:
<a class="moz-txt-link-freetext" href="http://git.yoctoproject.org/cgit.cgi/poky-contrib/commit/?h=ciorga/PUs&id=1dcbf3096d7d42032faade96dae89c25a4feca7a">http://git.yoctoproject.org/cgit.cgi/poky-contrib/commit/?h=ciorga/PUs&id=1dcbf3096d7d42032faade96dae89c25a4feca7a</a>
which would be the real bug?</pre>
</blockquote>
I am pretty sure they are<b> </b>NOT the same issue. The 1dcbf309
is about to fix gcc-crosssdk lacking its dependencies in bb, while
in this case, it's due to some other setscene
tasks(populate_sysroot) depended by gcc-crosssdk-initial's setscene
task(populate_sysroot) were not validated correctly, without the
modification to isNativeCross, the setscene_depvalid will return
TRUE through:<br>
......<br>
# Native/Cross populate_sysroot need their dependencies<br>
if isNativeCross(taskdependees[task][0]) and
isNativeCross(taskdependees[dep][0]):<br>
return False<br>
# Target populate_sysroot depended on by cross tools
need to be installed<br>
if isNativeCross(taskdependees[dep][0]):<br>
return False<br>
# Native/cross tools depended upon by target sysroot are
not needed<br>
if isNativeCross(taskdependees[task][0]):<br>
continue<br>
......<br>
return True<br>
......<br>
<br>
for example, when the task is 'gmp-native', and the dep is
'gcc-crosssdk-initial', it is absolutely wrong for
gcc-crosssdk-initial needs its dependencies like gmp-native,
libmpc-native, mpfr-native to be present in sysroot or its binaries
will fail to be executed.<br>
<br>
However, by double-checked the patch, I found that it had introduced
a regression that binutils-crosssdk should not be added into safe
dep list for it's in the DEPENDS of gcc-crosssdk-initial, I will
send a fix for it too.<br>
<br>
//Ming Liu<br>
<blockquote cite="mid:1389011136.22784.7.camel@ted" type="cite">
<pre wrap="">
Cheers,
Richard
</pre>
</blockquote>
<br>
</body>
</html>