<div dir="ltr"><div class="gmail_extra">On Tue, Feb 18, 2014 at 5:27 AM, Martin Jansa <span dir="ltr"><<a href="mailto:martin.jansa@gmail.com" target="_blank">martin.jansa@gmail.com</a>></span> wrote:<br><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div id=":225" style="overflow:hidden"> Maybe we should change meta/classes/package.<span class="il">bbclass</span> to<br>
fail when some filedeprunner call fails like this and fix<br>
filedeprunner to escape '()' and other possibly dangerous chars<br>
it's called like this:<br>
processed = list(pool.imap(oe.package.filedeprunner, pkglist))</div></blockquote></div><br></div><div class="gmail_extra">We'd likely be better off just avoiding os.popen entirely in favor of subprocess based operations, which generally support specifying the command arguments as a list, and can bypass the shell entirely, avoiding the need to escape anything. Alternatively, use os.popen2(), which can accept a list to bypass the shell as well.<br>
-- <br>Christopher Larson<br>clarson at kergoth dot com<br>Founder - BitBake, OpenEmbedded, OpenZaurus<br>Maintainer - Tslib<br>Senior Software Engineer, Mentor Graphics
</div></div>