<div dir="ltr"><div class="gmail_default" style="font-family:tahoma,sans-serif">I would think against it, because</div><div class="gmail_default" style="font-family:tahoma,sans-serif"><br></div><div class="gmail_default" style="font-family:tahoma,sans-serif">
- it's very inefficient to send a Skipped event for each missed task than to collect all the data and send it in one shot</div><div class="gmail_default" style="font-family:tahoma,sans-serif">- it's faster to send the event from the sstate.bbclass than to return the task ids and then call again a python function to generate the sstate file names - basically replicating the sstate.bbclass code in bitbake</div>
<div class="gmail_default" style="font-family:tahoma,sans-serif">- the queueTaskSkipped event has a different semantic than what we need here to return a whole batch of data; creating a new event type from scratch is a bit pointless since the inheritance would need to be broken</div>
<div class="gmail_default" style="font-family:tahoma,sans-serif">- knotty can receive MetadataEvents just as well as sceneTaskSkipped event, or any variation of it</div><div class="gmail_default" style="font-family:tahoma,sans-serif">
<br></div><div class="gmail_default" style="font-family:tahoma,sans-serif">I would suggest actually just sending this event at all times, not just when toaster is enabled.</div><div class="gmail_default" style="font-family:tahoma,sans-serif">
<br></div><div class="gmail_default" style="font-family:tahoma,sans-serif">Please advise,</div><div class="gmail_default" style="font-family:tahoma,sans-serif">Alex</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Thu, Feb 20, 2014 at 2:30 PM, Richard Purdie <span dir="ltr"><<a href="mailto:richard.purdie@linuxfoundation.org" target="_blank">richard.purdie@linuxfoundation.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="">On Mon, 2014-02-17 at 17:33 +0000, Alex DAMIAN wrote:<br>
> From: Alexandru DAMIAN <<a href="mailto:alexandru.damian@intel.com">alexandru.damian@intel.com</a>><br>
><br>
> Toaster needs to record the attempts to restore<br>
> setscene tasks that don't have a sstate file.<br>
><br>
> We build a list of tasks for which we can't find an<br>
> sstate file, and if we're running under Toaster data<br>
> collection, we send it off with a MetadataEvent.<br>
><br>
> Signed-off-by: Alexandru DAMIAN <<a href="mailto:alexandru.damian@intel.com">alexandru.damian@intel.com</a>><br>
> ---<br>
> meta/classes/sstate.bbclass | 11 +++++++++++<br>
> 1 file changed, 11 insertions(+)<br>
<br>
</div>I'm wondering if we should perhaps do this in bitbake and add a setscene<br>
"missed" event type there based upon the return value of this function?<br>
<br>
Ideally I'd like to be able to report the stats in knotty too.<br>
<br>
Cheers,<br>
<br>
Richard<br>
<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">Alex Damian<div>Yocto Project<br></div><div>SSG / OTC </div></div>
</div>