<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Feb 28, 2014 at 2:26 PM, Chris Larson <span dir="ltr"><<a href="mailto:clarson@kergoth.com" target="_blank">clarson@kergoth.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="gmail_extra">I'm guessing that the idea was to add a dependency from <span class="">diffconfig</span> to kernel_configme whether or not <span class="">diffconfig</span> even exists, in order to be able to support a use case where kernel-yocto is inherited but cml1 is not, but I'd question the validity of such a use case, personally. I think either we should consider one of these options:<br>
<br> 1) Programmatically add the dependency with bb.build.addtask based on the availability of do_diffconfig<br></div></blockquote><div><br><a href="https://gist.github.com/kergoth/9280305">https://gist.github.com/kergoth/9280305</a> shows what this one looks like, which is the most versatile, but does add additional processing at the end of parse time, though not much. I think this is probably our best bet as it still supports the use cases implied by the way kernel-yocto.bbclass and linux-yocto.inc are structured.<br>
</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="gmail_extra"> 2) Use addtask to express the dependency in linux-yocto.inc, where do_kernel_configme gets added as a task. Having do_diffconfig depend on do_kernel_configme for a recipe that doesn't include linux-yocto.inc would result in breakage anyway unless they explicitly addtask do_kernel_configme in that recipe.</div>
</blockquote></div><br><a href="https://gist.github.com/kergoth/9280352">https://gist.github.com/kergoth/9280352</a> shows this version, which would mean that anyone using kernel-yocto.bbclass and cml1.bbclass but not linux-yocto.bbclass wouldn't get the diffconfig -> kernel_configme dependency set<br>
-- <br>Christopher Larson<br>clarson at kergoth dot com<br>Founder - BitBake, OpenEmbedded, OpenZaurus<br>Maintainer - Tslib<br>Senior Software Engineer, Mentor Graphics
</div></div>