<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Apr 9, 2014 at 9:18 AM, Fathi Boudra <span dir="ltr"><<a href="mailto:fathi.boudra@linaro.org" target="_blank">fathi.boudra@linaro.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="">On 9 April 2014 18:02, Chris Larson <<a href="mailto:clarson@kergoth.com">clarson@kergoth.com</a>> wrote:<br>
><br>
> On Tue, Apr 8, 2014 at 10:16 AM, Fathi Boudra <<a href="mailto:fathi.boudra@linaro.org">fathi.boudra@linaro.org</a>><br>
> wrote:<br>
>><br>
>> On 8 April 2014 20:05, Khem Raj <<a href="mailto:raj.khem@gmail.com">raj.khem@gmail.com</a>> wrote:<br>
>> > On Tue, Apr 8, 2014 at 7:00 AM, Fathi Boudra <<a href="mailto:fathi.boudra@linaro.org">fathi.boudra@linaro.org</a>><br>
>> > wrote:<br>
>> >> do_install() {<br>
>> >> - oe_runmake prefix="${prefix}" DESTDIR="${D}" install<br>
>> >> + ${MAKE} NO_PYTHON=1 prefix=${prefix}<br>
>> >> plugin_dir=${libdir}/trace-cmd/plugins DESTDIR=${D} install<br>
>> >> }<br>
>> ><br>
>> > can you explain/document this change<br>
>><br>
>> sure. trace-cmd doesn't have a build system generated Makefile. It's<br>
>> hand written.<br>
>> To do the install properly, one has to pass prefix/plugin_dir.<br>
>> In addition, the previous command in the recipe doesn't do the right<br>
>> thing anymore (you'll end with duplicated prefix /usr/usr/).<br>
><br>
><br>
> You don't need to avoid the use of oe_runmake to pass variables in, that's<br>
> what EXTRA_OEMAKE is for :) See<br>
> <a href="https://github.com/MentorEmbedded/meta-mentor/commit/4639877" target="_blank">https://github.com/MentorEmbedded/meta-mentor/commit/4639877</a> for a version<br>
> of this fix that uses it instead.<br>
<br>
</div>You don't need oe_runmake or EXTRA_OEMAKE to properly build and<br>
install the files in the right path either :)<br>
You can even drop inherit pkgconfig pythonnative since they aren't<br>
used. My version is also slightly shorter to achieve the same goal.<br></blockquote><div><br></div><div>oe_runmake is the convention used by nearly every recipe in oe-core. Breaking that convention for no good reason accomplishes nothing.</div>
</div>-- <br>Christopher Larson<br>clarson at kergoth dot com<br>Founder - BitBake, OpenEmbedded, OpenZaurus<br>Maintainer - Tslib<br>Senior Software Engineer, Mentor Graphics
</div></div>