<div dir="ltr"><div>Hi list,</div><div><br></div><div>I'm forwarding this patch to oe-core list.</div><div>Thank you, Khem, for guiding me.</div><div><br></div><div>Kaz</div><br><div class="gmail_quote">---------- Forwarded message ----------<br>
From: <b class="gmail_sendername">Kazuya Nishimura</b> <span dir="ltr"><<a href="mailto:kazuya.nisimura@gmail.com">kazuya.nisimura@gmail.com</a>></span><br>Date: 2014-04-11 12:11 GMT+09:00<br>Subject: Re: [yocto] [meta-linaro][PATCH] external-linaro-toolchain: Fix for 32bit armhf build<br>
To: Khem Raj <<a href="mailto:raj.khem@gmail.com">raj.khem@gmail.com</a>><br>Cc: "<a href="mailto:yocto@yoctoproject.org">yocto@yoctoproject.org</a>" <<a href="mailto:yocto@yoctoproject.org">yocto@yoctoproject.org</a>><br>
<br><br><div dir="ltr">Hi Khem,<div class=""><div><br></div><div><span style="font-family:arial,sans-serif;font-size:14px">> why is chown needed here ?</span><br></div></div><div><span style="font-family:arial,sans-serif;font-size:14px">It is copied from original implementation.</span></div>
<div><font face="arial, sans-serif"><span style="font-size:14px">Please check do_install() in meta/recipes-core/eglibc/eglibc-locale.inc</span></font></div><div class=""><div><font face="arial, sans-serif"><span style="font-size:14px"><br>
</span></font></div><div><font face="arial, sans-serif"><span style="font-size:14px">> </span></font><span style="font-family:arial,sans-serif;font-size:14px">secondly, this piece should go into OE-Core</span></div></div>
<div>
<span style="font-family:arial,sans-serif;font-size:14px">maybe. </span></div><div><span style="font-family:arial,sans-serif;font-size:14px"><br></span></div><div><span style="font-family:arial,sans-serif;font-size:14px">Best regards,</span></div>
<div><span style="font-family:arial,sans-serif;font-size:14px">Kaz</span></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">2014-04-11 3:36 GMT+09:00 Khem Raj <span dir="ltr"><<a href="mailto:raj.khem@gmail.com" target="_blank">raj.khem@gmail.com</a>></span>:<div>
<div class="h5"><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>On Thu, Apr 10, 2014 at 12:49 AM, Kazuya Nishimura<br>
<<a href="mailto:kazuya.nisimura@gmail.com" target="_blank">kazuya.nisimura@gmail.com</a>> wrote:<br>
> From: Kazuya Nishimura <<a href="mailto:kazuya.nisimura@gmail.com" target="_blank">kazuya.nisimura@gmail.com</a>><br>
><br>
> Use ld-linux-armhf.so.3 if call convention hard.<br>
> Fix QA issue errors by packaging approprieately.<br>
> Add eglibc-locale_2.19.bbappend to fix QA issue error.<br>
> An empty directory is created while do_install.<br>
><br>
> Signed-off-by: Kazuya Nishimura <<a href="mailto:kazuya.nisimura@gmail.com" target="_blank">kazuya.nisimura@gmail.com</a>><br>
> ---<br>
> .../conf/distro/include/tcmode-external-linaro.inc | 1 +<br>
> .../eglibc/eglibc-locale_2.19.bbappend | 23 ++++++++++++<br>
> .../<a href="http://external-linaro-toolchain.bb" target="_blank">external-linaro-toolchain.bb</a> | 38<br>
> ++++++++++++++++----<br>
> 3 files changed, 56 insertions(+), 6 deletions(-)<br>
> create mode 100755<br>
> meta-linaro-toolchain/recipes-core/eglibc/eglibc-locale_2.19.bbappend<br>
><br>
> diff --git<br>
> a/meta-linaro-toolchain/conf/distro/include/tcmode-external-linaro.inc<br>
> b/meta-linaro-toolchain/conf/distro/include/tcmode-external-linaro.inc<br>
> index 1d9fd59..26d464c 100644<br>
> --- a/meta-linaro-toolchain/conf/distro/include/tcmode-external-linaro.inc<br>
> +++ b/meta-linaro-toolchain/conf/distro/include/tcmode-external-linaro.inc<br>
> @@ -41,6 +41,7 @@ DISTRO_FEATURES_LIBC = "ipv4 ipv6 libc-backtrace<br>
> libc-big-macros libc-bsd libc-c<br>
> libc-getlogin libc-idn libc-inet-anl libc-libm libc-libm-big \<br>
> libc-memusage libc-nis libc-nsswitch libc-rcmd libc-rtld-debug libc-spawn<br>
> libc-streams libc-sunrpc \<br>
> libc-utmp libc-utmpx libc-wordexp libc-posix-clang-wchar libc-posix-regexp<br>
> libc-posix-regexp-glibc \<br>
> + libc-charsets libc-locales libc-locale-code \<br>
> libc-posix-wchar-io"<br>
><br>
> ENABLE_BINARY_LOCALE_GENERATION = "0"<br>
> diff --git<br>
> a/meta-linaro-toolchain/recipes-core/eglibc/eglibc-locale_2.19.bbappend<br>
> b/meta-linaro-toolchain/recipes-core/eglibc/eglibc-locale_2.19.bbappend<br>
> new file mode 100755<br>
> index 0000000..3e91e74<br>
> --- /dev/null<br>
> +++ b/meta-linaro-toolchain/recipes-core/eglibc/eglibc-locale_2.19.bbappend<br>
> @@ -0,0 +1,23 @@<br>
> +do_install () {<br>
> + mkdir -p ${D}${datadir}<br>
> + if [ -n "$(ls ${LOCALETREESRC}/${bindir})" ]; then<br>
> + mkdir -p ${D}${bindir}<br>
> + cp -fpPR ${LOCALETREESRC}/${bindir}/* ${D}${bindir}<br>
> + fi<br>
> + if [ -n "$(ls ${LOCALETREESRC}/${localedir})" ]; then<br>
> + mkdir -p ${D}${localedir}<br>
> + cp -fpPR ${LOCALETREESRC}/${localedir}/* ${D}${localedir}<br>
> + fi<br>
> + if [ -e ${LOCALETREESRC}/${libdir}/gconv ]; then<br>
> + mkdir -p ${D}${libdir}<br>
> + cp -fpPR ${LOCALETREESRC}/${libdir}/gconv ${D}${libdir}<br>
> + fi<br>
> + if [ -e ${LOCALETREESRC}/${datadir}/i18n ]; then<br>
> + cp -fpPR ${LOCALETREESRC}/${datadir}/i18n ${D}${datadir}<br>
> + fi<br>
> + if [ -e ${LOCALETREESRC}/${datadir}/locale ]; then<br>
> + cp -fpPR ${LOCALETREESRC}/${datadir}/locale ${D}${datadir}<br>
> + fi<br>
> + chown root.root -R ${D}<br>
> + cp -fpPR ${LOCALETREESRC}/SUPPORTED ${WORKDIR}<br>
> +}<br>
<br>
</div></div>why is chown needed here ?<br>
secondly, this piece should go into OE-Core<br>
<div><div><br>
> diff --git<br>
> a/meta-linaro-toolchain/recipes-devtools/external-linaro-toolchain/<a href="http://external-linaro-toolchain.bb" target="_blank">external-linaro-toolchain.bb</a><br>
> b/meta-linaro-toolchain/recipes-devtools/external-linaro-toolchain/<a href="http://external-linaro-toolchain.bb" target="_blank">external-linaro-toolchain.bb</a><br>
> index 240d550..47fd4ca 100644<br>
> ---<br>
> a/meta-linaro-toolchain/recipes-devtools/external-linaro-toolchain/<a href="http://external-linaro-toolchain.bb" target="_blank">external-linaro-toolchain.bb</a><br>
> +++<br>
> b/meta-linaro-toolchain/recipes-devtools/external-linaro-toolchain/<a href="http://external-linaro-toolchain.bb" target="_blank">external-linaro-toolchain.bb</a><br>
> @@ -41,6 +41,12 @@ PROVIDES += "\<br>
> libitm \<br>
> libitm-dev \<br>
> libitm-staticdev \<br>
> + libasan \<br>
> + libasan-dev \<br>
> + libasan-staticdev \<br>
> + libatomic \<br>
> + libatomic-dev \<br>
> + libatomic-staticdev \<br>
> virtual/linux-libc-headers \<br>
> "<br>
><br>
> @@ -50,12 +56,11 @@ PR = "r2"<br>
> # <a href="https://launchpad.net/linaro-toolchain-binaries" target="_blank">https://launchpad.net/linaro-toolchain-binaries</a><br>
> SRC_URI = "file://SUPPORTED"<br>
><br>
> +LDLINUX32 = "${@base_contains("TUNE_FEATURES", "callconvention-hard",<br>
> "ld-linux-armhf.so.3", "ld-linux.so.3",d)}"<br>
> +<br>
> do_install() {<br>
> install -d ${D}${base_libdir}<br>
> - install -d ${D}${bindir}<br>
> - install -d ${D}${sbindir}<br>
> install -d ${D}${libdir}<br>
> - install -d ${D}${libexecdir}<br>
> install -d ${D}${datadir}<br>
> install -d ${D}${includedir}<br>
><br>
> @@ -79,7 +84,7 @@ do_install() {<br>
> fi<br>
><br>
> # fix up the copied symlinks (they are still pointing to the multiarch<br>
> directory)<br>
> - linker_name="${@base_contains("TUNE_FEATURES", "aarch64",<br>
> "ld-linux-aarch64.so.1", "ld-linux.so.3",d)}"<br>
> + linker_name="${@base_contains("TUNE_FEATURES", "aarch64",<br>
> "ld-linux-aarch64.so.1", "${LDLINUX32}",d)}"<br>
> ln -sf ld-${ELT_VER_LIBC}.so ${D}${base_libdir}/${linker_name}<br>
> ln -sf ../../lib/libnsl.so.1 ${D}${libdir}/libnsl.so<br>
> ln -sf ../../lib/librt.so.1 ${D}${libdir}/librt.so<br>
> @@ -144,6 +149,12 @@ PACKAGES =+ "\<br>
> libitm \<br>
> libitm-dev \<br>
> libitm-staticdev \<br>
> + libasan \<br>
> + libasan-dev \<br>
> + libasan-staticdev \<br>
> + libatomic \<br>
> + libatomic-dev \<br>
> + libatomic-staticdev \<br>
> "<br>
><br>
> INSANE_SKIP_${PN}-dbg = "staticdev"<br>
> @@ -282,14 +293,16 @@ FILES_libssp-staticdev = " \<br>
><br>
> FILES_libgfortran = "${base_libdir}/libgfortran.so.*"<br>
> FILES_libgfortran-dev = " \<br>
> - ${base_libdir}/libgfortran.so"<br>
> + ${base_libdir}/libgfortran.so \<br>
> + ${base_libdir}/libgfortran.spec"<br>
> FILES_libgfortran-staticdev = " \<br>
> ${base_libdir}/libgfortran.a \<br>
> ${base_libdir}/libgfortranbegin.a"<br>
><br>
> FILES_libmudflap = "${base_libdir}/libmudflap*.so.*"<br>
> FILES_libmudflap-dev = "\<br>
> - ${base_libdir}/libmudflap*.so \<br>
> + ${base_libdir}/libmudflap*.so"<br>
> +FILES_libmudflap-staticdev = "\<br>
> ${base_libdir}/libmudflap*.a \<br>
> ${base_libdir}/libmudflap*.la"<br>
><br>
> @@ -313,6 +326,19 @@ FILES_libgomp-dev = "\<br>
> FILES_libgomp-staticdev = "\<br>
> ${base_libdir}/libgomp*.a \<br>
> "<br>
> +<br>
> +FILES_libasan = "\<br>
> + ${base_libdir}/libasan.so.* \<br>
> + "<br>
> +FILES_libasan-dev = "\<br>
> + ${base_libdir}/libasan.so \<br>
> + "<br>
> +FILES_libatomic ="\<br>
> + ${base_libdir}/libatomic.so.* \<br>
> + "<br>
> +FILES_libatomic-dev = "\<br>
> + ${base_libdir}/libatomic.so \<br>
> + "<br>
> ELT_VER_MAIN ??= ""<br>
><br>
> python () {<br>
> --<br>
> 1.7.9.5<br>
><br>
><br>
</div></div><span><font color="#888888">> --<br>
> _______________________________________________<br>
> yocto mailing list<br>
> <a href="mailto:yocto@yoctoproject.org" target="_blank">yocto@yoctoproject.org</a><br>
> <a href="https://lists.yoctoproject.org/listinfo/yocto" target="_blank">https://lists.yoctoproject.org/listinfo/yocto</a><br>
><br>
</font></span></blockquote></div></div></div><br></div>
</div><br></div>