<br><br>On Tuesday, September 23, 2014, <<a href="mailto:ting.liu@freescale.com">ting.liu@freescale.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Ting Liu <<a href="javascript:;" onclick="_e(event, 'cvml', 'ting.liu@freescale.com')">ting.liu@freescale.com</a>><br>
<br>
none/tests/ppc64/Makefile.am (and ppc32, too) passes the flag -maltivec<br>
unconditionally. Build will fail if Altivec not supported. add the flag<br>
only if HAS_ALTIVEC defined.<br>
<br></blockquote><div><br></div><div>Why would you use altivec abi without altivec being found. Cover that in checks too please </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Reference:<br>
see <a href="https://bugs.kde.org/show_bug.cgi?id=338731" target="_blank">https://bugs.kde.org/show_bug.cgi?id=338731</a><br>
<br>
Signed-off-by: Ting Liu <<a href="javascript:;" onclick="_e(event, 'cvml', 'ting.liu@freescale.com')">ting.liu@freescale.com</a>><br>
---<br>
.../pass-maltivec-only-if-it-supported.patch | 68 ++++++++++++++++++++++<br>
meta/recipes-devtools/valgrind/<a href="http://valgrind_3.9.0.bb" target="_blank">valgrind_3.9.0.bb</a> | 1 +<br>
2 files changed, 69 insertions(+)<br>
create mode 100644 meta/recipes-devtools/valgrind/valgrind/pass-maltivec-only-if-it-supported.patch<br>
<br>
diff --git a/meta/recipes-devtools/valgrind/valgrind/pass-maltivec-only-if-it-supported.patch b/meta/recipes-devtools/valgrind/valgrind/pass-maltivec-only-if-it-supported.patch<br>
new file mode 100644<br>
index 0000000..3781466<br>
--- /dev/null<br>
+++ b/meta/recipes-devtools/valgrind/valgrind/pass-maltivec-only-if-it-supported.patch<br>
@@ -0,0 +1,68 @@<br>
+Upstream-status: pending<br>
+<br>
+pass -maltivec only if it supported<br>
+<br>
+none/tests/ppc64/Makefile.am (and ppc32, too) passes the flag -maltivec<br>
+unconditionally. Build will fail if Altivec not supported. add the flag<br>
+only if HAS_ALTIVEC defined.<br>
+<br>
+Reference:<br>
+see <a href="https://bugs.kde.org/show_bug.cgi?id=338731" target="_blank">https://bugs.kde.org/show_bug.cgi?id=338731</a><br>
+<br>
+Index: none/tests/ppc32/Makefile.am<br>
+===================================================================<br>
+--- a/none/tests/ppc32/Makefile.am (revision 14477)<br>
++++ b/none/tests/ppc32/Makefile.am (working copy)<br>
+@@ -72,8 +72,10 @@<br>
+ allexec_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_NONNULL@<br>
+<br>
+ if HAS_ALTIVEC<br>
++BUILD_FLAG_ALTIVEC = -maltivec<br>
+ ALTIVEC_FLAG = -DHAS_ALTIVEC<br>
+ else<br>
++BUILD_FLAG_ALTIVEC =<br>
+ ALTIVEC_FLAG =<br>
+ endif<br>
+<br>
+@@ -101,11 +103,11 @@<br>
+ ISA_2_07_FLAG =<br>
+ endif<br>
+<br>
+-jm_insns_CFLAGS = $(AM_CFLAGS) -Winline -Wall -O -g -mregnames -maltivec \<br>
+- @FLAG_M32@ $(ALTIVEC_FLAG)<br>
++jm_insns_CFLAGS = $(AM_CFLAGS) -Winline -Wall -O -g -mregnames \<br>
++ @FLAG_M32@ $(ALTIVEC_FLAG) $(BUILD_FLAG_ALTIVEC)<br>
+<br>
+-testVMX_CFLAGS = $(AM_CFLAGS) -O -g -Wall -maltivec -mabi=altivec -DALTIVEC \<br>
+- -DGCC_COMPILER @FLAG_M32@<br>
++testVMX_CFLAGS = $(AM_CFLAGS) -O -g -Wall -mabi=altivec -DALTIVEC \<br>
++ -DGCC_COMPILER @FLAG_M32@ $(BUILD_FLAG_ALTIVEC)<br>
+<br>
+ test_isa_2_06_part1_CFLAGS = $(AM_CFLAGS) -Winline -Wall -O -g -mregnames $(VSX_FLAG) \<br>
+ @FLAG_M32@ $(ALTIVEC_FLAG) $(BUILD_FLAG_VSX)<br>
+Index: none/tests/ppc64/Makefile.am<br>
+===================================================================<br>
+--- a/none/tests/ppc64/Makefile.am (revision 14477)<br>
++++ b/none/tests/ppc64/Makefile.am (working copy)<br>
+@@ -50,8 +50,10 @@<br>
+ allexec_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_NONNULL@<br>
+<br>
+ if HAS_ALTIVEC<br>
++BUILD_FLAG_ALTIVEC = -maltivec<br>
+ ALTIVEC_FLAG = -DHAS_ALTIVEC<br>
+ else<br>
++BUILD_FLAG_ALTIVEC =<br>
+ ALTIVEC_FLAG =<br>
+ endif<br>
+<br>
+@@ -88,8 +90,8 @@<br>
+ test_isa_2_06_part3_CFLAGS = $(AM_CFLAGS) -Winline -Wall -O -g -mregnames $(VSX_FLAG) \<br>
+ @FLAG_M64@ $(ALTIVEC_FLAG) $(BUILD_FLAG_VSX)<br>
+<br>
+-jm_insns_CFLAGS = $(AM_CFLAGS) -Winline -Wall -O -g -mregnames -maltivec \<br>
+- @FLAG_M64@ $(ALTIVEC_FLAG)<br>
++jm_insns_CFLAGS = $(AM_CFLAGS) -Winline -Wall -O -g -mregnames \<br>
++ @FLAG_M64@ $(ALTIVEC_FLAG) $(BUILD_FLAG_ALTIVEC)<br>
+<br>
+ test_dfp1_CFLAGS = $(AM_CFLAGS) -Winline -Wall -O -g -mregnames $(DFP_FLAG) \<br>
+ @FLAG_M64@ $(BUILD_FLAGS_DFP)<br>
diff --git a/meta/recipes-devtools/valgrind/<a href="http://valgrind_3.9.0.bb" target="_blank">valgrind_3.9.0.bb</a> b/meta/recipes-devtools/valgrind/<a href="http://valgrind_3.9.0.bb" target="_blank">valgrind_3.9.0.bb</a><br>
index c415e77..58bb9eb 100644<br>
--- a/meta/recipes-devtools/valgrind/<a href="http://valgrind_3.9.0.bb" target="_blank">valgrind_3.9.0.bb</a><br>
+++ b/meta/recipes-devtools/valgrind/<a href="http://valgrind_3.9.0.bb" target="_blank">valgrind_3.9.0.bb</a><br>
@@ -19,6 +19,7 @@ SRC_URI = "<a href="http://www.valgrind.org/downloads/valgrind-${PV}.tar.bz2" target="_blank">http://www.valgrind.org/downloads/valgrind-${PV}.tar.bz2</a> \<br>
file://force-nostabs.patch \<br>
file://remove-arm-variant-specific.patch \<br>
file://remove-ppc-tests-failing-build.patch \<br>
+ file://pass-maltivec-only-if-it-supported.patch \<br>
file://add-ptest.patch \<br>
file://run-ptest \<br>
"<br>
--<br>
1.8.3.2<br>
<br>
--<br>
_______________________________________________<br>
Openembedded-core mailing list<br>
<a href="javascript:;" onclick="_e(event, 'cvml', 'Openembedded-core@lists.openembedded.org')">Openembedded-core@lists.openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
</blockquote>