<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On 12 November 2014 17:18, Alejandro Hernandez <span dir="ltr">&lt;<a href="mailto:alejandro.hernandez@linux.intel.com" target="_blank">alejandro.hernandez@linux.intel.com</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Signed-off-by: Alejandro Hernandez &lt;<a href="mailto:alejandro.hernandez@linux.intel.com">alejandro.hernandez@linux.intel.com</a>&gt;<br>
---<br>
 meta/recipes-extended/cronie/<a href="http://cronie_1.4.11.bb" target="_blank">cronie_1.4.11.bb</a> | 85 ---------------------------<br>
 meta/recipes-extended/cronie/<a href="http://cronie_1.4.12.bb" target="_blank">cronie_1.4.12.bb</a> | 84 ++++++++++++++++++++++++++<br></blockquote><div><br></div><div>Please pass -M to git-send-email if you&#39;re sending patches without using create-pull-request so that the rename is spotted and the diff is much easier to read. I applied and re-generated the diff:</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">--- a/meta/recipes-extended/cronie/<a href="http://cronie_1.4.11.bb">cronie_1.4.11.bb</a><br>+++ b/meta/recipes-extended/cronie/<a href="http://cronie_1.4.12.bb">cronie_1.4.12.bb</a><br>@@ -8,7 +8,7 @@ BUGTRACKER = &quot;<a href="mailto:mmaslano@redhat.com">mmaslano@redhat.com</a>&quot;<br> # Internet Systems Consortium License<br> LICENSE = &quot;ISC &amp; BSD&quot;<br>-LIC_FILES_CHKSUM = &quot;file://COPYING;md5=963ea0772a2adbdcd607a9b2ec320c11 \<br>+LIC_FILES_CHKSUM = &quot;file://COPYING;md5=dd2a592170760e1386c769e1043b3722 \<br>                     file://src/cron.c;endline=20;md5=b425c334265026177128353a142633b4 \</blockquote><div><br></div><div>Always say why the license checksum was change in the commit message.  Often it&#39;s just copyright dates changing or reformatting, but we need to know that it&#39;s not that the license terms were changed. </div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"> SRC_URI = &quot;<a href="https://fedorahosted.org/releases/c/r/cronie/cronie-${PV}.tar.gz">https://fedorahosted.org/releases/c/r/cronie/cronie-${PV}.tar.gz</a> \<br>-           file://fix-out-of-tree-build.patch \<br></blockquote><div><br></div><div>If a patch is removed explain why (upstream merged it in this case, I hope), and remember to remove the file in the commit.</div><div><br></div><div>Ross </div></div><br></div></div>