<div dir="ltr">I find Koen's patch for libpng neater so could you merge that into your qemuarm64 branch? The autobuilder has been doing some builds so this should be the last stage before it's all merged.<div><br></div><div>Ross</div></div><div class="gmail_extra"><br><div class="gmail_quote">On 17 December 2014 at 08:47, Kang Kai <span dir="ltr"><<a href="mailto:Kai.Kang@windriver.com" target="_blank">Kai.Kang@windriver.com</a>></span> wrote:<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"><div><div class="h5">
<div>On 2014年12月17日 03:30, Koen Kooi wrote:<br>
</div>
<blockquote type="cite">
<pre></pre>
<blockquote type="cite">
<pre>Op 7 nov. 2014, om 09:51 heeft Kai Kang <a href="mailto:kai.kang@windriver.com" target="_blank"><kai.kang@windriver.com></a> het volgende geschreven:
Add neon option for aarch64 just as for arm. It fails with:
| ./.libs/libpng16.so: undefined reference to `png_init_filter_functions_neon'
| collect2: error: ld returned 1 exit status
Signed-off-by: Kai Kang <a href="mailto:kai.kang@windriver.com" target="_blank"><kai.kang@windriver.com></a>
---
meta/recipes-multimedia/libpng/<a href="http://libpng_1.6.13.bb" target="_blank">libpng_1.6.13.bb</a> | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta/recipes-multimedia/libpng/<a href="http://libpng_1.6.13.bb" target="_blank">libpng_1.6.13.bb</a> b/meta/recipes-multimedia/libpng/<a href="http://libpng_1.6.13.bb" target="_blank">libpng_1.6.13.bb</a>
index 0c6fd1f..3d32bfe 100644
--- a/meta/recipes-multimedia/libpng/<a href="http://libpng_1.6.13.bb" target="_blank">libpng_1.6.13.bb</a>
+++ b/meta/recipes-multimedia/libpng/<a href="http://libpng_1.6.13.bb" target="_blank">libpng_1.6.13.bb</a>
@@ -20,6 +20,7 @@ inherit autotools binconfig-disabled pkgconfig
# Work around missing symbols
EXTRA_OECONF_append_arm = " ${@bb.utils.contains("TUNE_FEATURES", "neon", "--enable-arm-neon=on", "--enable-arm-neon=off" ,d)}"
+EXTRA_OECONF_append_aarch64 = " ${@bb.utils.contains("TUNE_FEATURES", "neon", "--enable-arm-neon=on", "--enable-arm-neon=off" ,d)}"
</pre>
</blockquote>
<pre>You're introducing the same bug in a different way: overeager use of qualifiers. Just drop the _arm bit and it works.
</pre>
</blockquote>
<br>
</div></div><font size="+1">OK. I'll remove the _arm to fix this issue.<br>
<br>
Thanks.<span class="HOEnZb"><font color="#888888"><br>
</font></span></font><span class="HOEnZb"><font color="#888888"><br>
<pre cols="72">--
Regards,
Neil | Kai Kang</pre>
</font></span></div>
</blockquote></div></div>