<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On 25 February 2015 at 15:15, Cristian Iorga <span dir="ltr"><<a href="mailto:cristian.iorga@intel.com" target="_blank">cristian.iorga@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div id=":59r" class="a3s" style="overflow:hidden">oe.utils.<span class="il">both_contain</span>() just does a find() on the value<br>
rather than splitting the value and then looking in the<br>
list of split items. The result is that if you add a<br>
feature to MACHINE_FEATURES that itself has a substring<br>
that matches one of the values looked for when building<br>
COMBINED_FEATURES, you end up with an incomprehensible<br>
error (here with "ext2i" in MACHINE_FEATURES):</div></blockquote></div><br>This looks right but you know what it needs: a test suite. Add a small test case that demonstrates it breaking before the fix and then working after the fix. We've been adding test cases to bitbake as bugs are found and it's really helping demonstrate that changes work.</div><div class="gmail_extra"><br></div><div class="gmail_extra">Ross</div></div>