<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On 11 April 2015 at 02:20, Khem Raj <span dir="ltr">&lt;<a href="mailto:raj.khem@gmail.com" target="_blank">raj.khem@gmail.com</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">++#ifdef __GLIBC__<br>
</blockquote><div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">+ #include &lt;execinfo.h&gt;<br></blockquote></div><div><br></div><div>As you&#39;re checking for this header at configure time wouldn&#39;t it be best to use #ifdef HAVE_EXECINFO_H, just in case another C library adds it later?</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">+ /* from netinet/in.h */<br></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
++#if 0<br>
+ struct in6_pktinfo {<br>
+       struct in6_addr ipi6_addr;  /* src/dst IPv6 address */<br>
+       unsigned int ipi6_ifindex;  /* send/recv interface index */<br>
+ };<br>
++#endif<br>
</blockquote><div><br></div><div>#if 0?  Is this entirely redundant code (in which case, delete it), or is this disabling something?</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">++++ b/gweb/gresolv.c<br>
+@@ -876,8 +876,6 @@ GResolv *g_resolv_new(int index)<br>
+       resolv-&gt;index = index;<br>
+       resolv-&gt;nameserver_list = NULL;<br>
+<br>
+-      res_ninit(&amp;resolv-&gt;res);<br>
+-<br>
+       return resolv;<br>
+ }<br>
+<br>
+@@ -917,8 +915,6 @@ void g_resolv_unref(GResolv *resolv)<br>
+<br>
+       flush_nameservers(resolv);<br>
+<br>
+-      res_nclose(&amp;resolv-&gt;res);<br>
+-<br>
+       g_free(resolv);<br>
+ }<br>
</blockquote><div><br></div><div>Surely these should be checked at configure time or wrapped in GLIBC tests, with the new codepath as a fallback.  Ideally we can upstream most of this.</div><div> </div><div>Ross </div></div></div></div>