<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Apr 13, 2015, at 9:50 AM, Burton, Ross <<a href="mailto:ross.burton@intel.com" class="">ross.burton@intel.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote">On 11 April 2015 at 02:20, Khem Raj <span dir="ltr" class=""><<a href="mailto:raj.khem@gmail.com" target="_blank" class="">raj.khem@gmail.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">++#ifdef __GLIBC__<br class="">
</blockquote><div class=""><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">+ #include <execinfo.h><br class=""></blockquote></div></div></div></div></div></blockquote><div><br class=""></div><div>yeah ideally, I could just use libunwind and get the backtrace API for musl too but I will do that when I need it.</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><div class=""><br class=""></div><div class="">As you're checking for this header at configure time wouldn't it be best to use #ifdef HAVE_EXECINFO_H, just in case another C library adds it later?</div><div class=""><br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">+ /* from netinet/in.h */<br class=""></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
++#if 0<br class="">
+ struct in6_pktinfo {<br class="">
+ struct in6_addr ipi6_addr; /* src/dst IPv6 address */<br class="">
+ unsigned int ipi6_ifindex; /* send/recv interface index */<br class="">
+ };<br class="">
++#endif<br class="">
</blockquote><div class=""><br class=""></div><div class="">#if 0? Is this entirely redundant code (in which case, delete it), or is this disabling something?</div></div></div></div></div></blockquote><div><br class=""></div><div style="widows: 1;">it is redundant if you are including <font color="#500050" face="arial, sans-serif" size="2" class=""><span style="background-color: rgb(255, 255, 255);" class="">netinet/in.h</span></font></div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><div class=""> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">++++ b/gweb/gresolv.c<br class="">
+@@ -876,8 +876,6 @@ GResolv *g_resolv_new(int index)<br class="">
+ resolv->index = index;<br class="">
+ resolv->nameserver_list = NULL;<br class="">
+<br class="">
+- res_ninit(&resolv->res);<br class="">
+-<br class="">
+ return resolv;<br class="">
+ }<br class="">
+<br class="">
+@@ -917,8 +915,6 @@ void g_resolv_unref(GResolv *resolv)<br class="">
+<br class="">
+ flush_nameservers(resolv);<br class="">
+<br class="">
+- res_nclose(&resolv->res);<br class="">
+-<br class="">
+ g_free(resolv);<br class="">
+ }<br class="">
</blockquote><div class=""><br class=""></div><div class="">Surely these should be checked at configure time or wrapped in GLIBC tests, with the new codepath as a fallback. Ideally we can upstream most of this.</div><div class=""> </div><div class="">Ross </div></div></div></div>
</div></blockquote></div><br class=""></body></html>