<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 70.85pt 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="FR" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Hi Ross,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">I didn’t know such a function was existing. You can use it of course, it’s much better.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">I found the (obscure) regexp in libcgroup recipe, it could be updated too.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Is it worth it I send a v2 patch ?<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Matthieu<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">De :</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Burton, Ross [mailto:ross.burton@intel.com]
<br>
<b>Envoyé :</b> mercredi 20 mai 2015 16:42<br>
<b>À :</b> Matthieu CRAPET<br>
<b>Cc :</b> openembedded-core@lists.openembedded.org<br>
<b>Objet :</b> Re: [OE-core] [PATCH] zlib: minor symbolic link issue<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">On 20 May 2015 at 10:47, Matthieu CRAPET <<a href="mailto:Matthieu.CRAPET@ingenico.com" target="_blank">Matthieu.CRAPET@ingenico.com</a>> wrote:<o:p></o:p></p>
<div>
<p class="MsoNormal">Just tell me if something is wrong, I can provide a v2 patch.<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><br>
No, it just slipped through the cracks.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">That regex looked a bit obscure, and there's a Python function we provide that uses the Python standard library to do the same thing, so I ended up with this locally:<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<div>
<p class="MsoNormal"># Move zlib shared libraries for target builds to $base_libdir so the library<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"># can be used in early boot before $prefix is mounted.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">do_install_append_class-target() {<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> if [ ${base_libdir} != ${libdir} ]<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> then<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> mkdir -p ${D}/${base_libdir}<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> mv ${D}/${libdir}/libz.so.* ${D}/${base_libdir}<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> libname=`readlink ${D}/${libdir}/libz.so`<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> ln -sf <a href="mailto:$%7b@oe.path.relative(%22$%7blibdir%7d">
${@oe.path.relative("${libdir}</a>", "${base_libdir}")}/$libname ${D}${libdir}/libz.so<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> fi<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">}<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Do you have any objections to this form instead? I'm also thinking we should rationalise the duplicated logic into a single implementation in meta/classes/utils.bbclass...<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Ross<o:p></o:p></p>
</div>
</div>
</div>
</div>
</body>
</html>