<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On 21 May 2015 at 09:21, Ismo Puustinen <span dir="ltr"><<a href="mailto:ismo.puustinen@intel.com" target="_blank">ismo.puustinen@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div id=":al1" class="a3s" style="overflow:hidden">I recently wrote my own parser for BitBake recipes and ran it over the recipes<br>
in openembedded-core. I found a number of bugs in my parser, but I also saw some<br>
"patterns" in recipes which I thought were against the spec but still allowed by<br>
the BitBake parser.<br>
<br>
This patch series fixes quotes in variable values. Specifically, it disallows<br>
having unescaped double quotes inside a variable value that is surrounded by<br>
double quotes. This patch series in not critical in that sense that everything<br>
should work still the same way it used to. However, if the BitBake parser is<br>
ever made stricter or the BitBake User Manual written to have less ambiguity on<br>
the subject of the .bb file format, having these fixed will help in transition.<br>
<br>
Of course, it may be that I'm mistaken and the quoting around variable values is<br>
not even supposed to have a meaning in the variable definition, in which case<br>
the whole patch set can be disregarded.</div></blockquote></div><br>This is going to sound really petty... but 99% of assignments in the metadata use double quotes so for consistency the patches were possible should use double quotes on the outside and single quotes on the inside.</div><div class="gmail_extra"><br></div><div class="gmail_extra">And yes, bitbake's string parser isn't a strict as you'd expect.</div><div class="gmail_extra"><br></div><div class="gmail_extra">Ross</div></div>