<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jul 13, 2015 at 6:19 PM, zhangxiao <span dir="ltr"><<a href="mailto:xiao.zhang@windriver.com" target="_blank">xiao.zhang@windriver.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>On 2015年07月13日 22:28, Christopher Larson wrote:<br>
</span><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>
<br>
On Sun, Jul 12, 2015 at 11:10 PM, Zhang Xiao <<a href="mailto:xiao.zhang@windriver.com" target="_blank">xiao.zhang@windriver.com</a><br></span><span>
<mailto:<a href="mailto:xiao.zhang@windriver.com" target="_blank">xiao.zhang@windriver.com</a>>> wrote:<br>
<br>
Upstream-Status: pending<br>
<br>
Signed-off-by: Zhang Xiao <<a href="mailto:xiao.zhang@windriver.com" target="_blank">xiao.zhang@windriver.com</a><br></span>
<mailto:<a href="mailto:xiao.zhang@windriver.com" target="_blank">xiao.zhang@windriver.com</a>>><span><br>
<br>
<br>
There’s no info on why this is being done, only what’s being done, in<br>
this commit message.<br>
</span></blockquote>
<br>
Binary logrotate should be installed in /usr/sbin and int fact, at the very<br>
beginning, it was there. While with commit a46d3646a3e1781be44:<br>
...<br>
logrotate: obey our flags<br>
<br>
Needed to quiet GNU_HASH warnings, and some minor fixes.<br>
...<br>
<br>
Part of its modification as below:<br>
...<span><br>
- oe_runmake install DESTDIR=${D} PREFIX=${D} MANDIR=${mandir}<br></span>
+ oe_runmake install DESTDIR=${D} PREFIX=${D} MANDIR=${mandir} BINDIR=${bindir}<br>
...<br>
moves it to /usr/bin. It is not correct, so move it back to<br>
/usr/sbin with ${sbindir}.<br></blockquote></div><br>That’s entirely reasonable, but at least some reference to that needs to be in the commit message, not just email discussion :)<br>-- <br><div>Christopher Larson<br>clarson at kergoth dot com<br>Founder - BitBake, OpenEmbedded, OpenZaurus<br>Maintainer - Tslib<br>Senior Software Engineer, Mentor Graphics</div>
</div></div>