<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Jul 16, 2015, at 11:45 AM, Martin Jansa <<a href="mailto:martin.jansa@gmail.com" class="">martin.jansa@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">On Thu, Jul 16, 2015 at 11:12:04AM -0400, Drew Moseley wrote:</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">The existing test for GLU support is backwards. Reverse the<br class="">sense of the conditional when built with "--enable-glu".<br class=""><br class="">Signed-off-by: Drew Moseley <<a href="mailto:drew_moseley@mentor.com" class="">drew_moseley@mentor.com</a>><br class="">---<br class="">...figure-Allow-to-disable-demos-which-require-GLEW-.patch | 14 ++++++++------<br class="">1 file changed, 8 insertions(+), 6 deletions(-)<br class=""><br class="">diff --git a/meta/recipes-graphics/mesa/mesa-demos/0003-configure-Allow-to-disable-demos-which-require-GLEW-.patch b/meta/recipes-graphics/mesa/mesa-demos/0003-configure-Allow-to-disable-demos-which-require-GLEW-.patch<br class="">index 4b07193..b25f5ce 100644<br class="">--- a/meta/recipes-graphics/mesa/mesa-demos/0003-configure-Allow-to-disable-demos-which-require-GLEW-.patch<br class="">+++ b/meta/recipes-graphics/mesa/mesa-demos/0003-configure-Allow-to-disable-demos-which-require-GLEW-.patch<br class="">@@ -10,20 +10,21 @@ Subject: [PATCH 3/9] configure: Allow to disable demos which require GLEW or<br class="">Upstream-Status: Pending<br class=""><br class="">Signed-off-by: Martin Jansa <<a href="mailto:Martin.Jansa@gmail.com" class="">Martin.Jansa@gmail.com</a>><br class="">+Signed-off-by: Drew Moseley <<a href="mailto:drew_moseley@mentor.com" class="">drew_moseley@mentor.com</a>><br class="">---<br class="">- configure.ac | 49 ++++++++++++++++++++---------<br class="">- src/Makefile.am | 14 ++++++---<br class="">+ configure.ac | 50 ++++++++++++++++++++---------<br class="">+ src/Makefile.am | 18 ++++++++---<br class=""> src/demos/Makefile.am | 73 ++++++++++++++++++++++++-------------------<br class=""> src/egl/Makefile.am | 8 +++--<br class=""> src/egl/opengles1/Makefile.am | 44 +++++++++++++++-----------<br class=""> src/egl/opengles2/Makefile.am | 33 ++++++++++---------<br class="">- 6 files changed, 135 insertions(+), 86 deletions(-)<br class="">+ 6 files changed, 140 insertions(+), 86 deletions(-)<br class=""><br class="">diff --git a/configure.ac b/configure.ac<br class="">index 9445424..bc4c8d1 100644<br class="">--- a/configure.ac<br class="">+++ b/configure.ac<br class="">-@@ -93,25 +93,44 @@ AC_EGREP_HEADER([glutInitContextProfile],<br class="">+@@ -89,25 +89,45 @@ AC_EGREP_HEADER([glutInitContextProfile],<br class=""> <span class="Apple-tab-span" style="white-space: pre;"> </span><span class="Apple-tab-span" style="white-space: pre;"> </span>[AC_DEFINE(HAVE_FREEGLUT)],<br class=""> <span class="Apple-tab-span" style="white-space: pre;"> </span><span class="Apple-tab-span" style="white-space: pre;"> </span>[])<br class=""><br class="">@@ -66,7 +67,7 @@ index 9445424..bc4c8d1 100644<br class="">-DEMO_CFLAGS="$DEMO_CFLAGS $GLU_CFLAGS"<br class="">-DEMO_LIBS="$DEMO_LIBS $GLU_LIBS"<br class="">+if test "x$enable_glu" = xyes; then<br class="">-+ PKG_CHECK_MODULES(GLU, [glu], [],<br class="">++ PKG_CHECK_MODULES(GLU, [glu],<br class=""></blockquote><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Are you sure? It was like this in original PKG_CHECK_MODULES and I think</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">it was correct. 4th parameter is used as fallback to find it manually</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">when pkg-config doesn't find it, with your change it would use</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">AC_CHECK_HEADER and ignore the values set returned by pkg-config.</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""></div></blockquote></div><div class=""><br class=""></div><div class="">Hi Martin,</div><div class=""><br class=""></div><div class="">I’m fairly certain this is needed however I’m not terribly familiar with autotools so it’s possible I missed something. I know that without this change a number of the demo apps I expect do not get built. It’s been a while since I looked but I seem to recall that the “geartrain” demo among others will not be available without this change.</div><div class=""><br class=""></div><div class="">From my reading of the PKG_CHECK_MODULES docs at <a href="https://autotools.io/pkgconfig/pkg_check_modules.html" class="">https://autotools.io/pkgconfig/pkg_check_modules.html</a>, it seems the 3rd parameter is the action-if-found and my read of the logic here is that if glu is found it then verifies the presence of the header files and libs.</div><div class=""><br class=""></div><div class="">I’ll kick off a fresh build and dig around a bit just in case I missed something.</div><div class=""><br class=""></div><div class="">Regards,</div><div class=""><br class=""></div><div class="">Drew</div></body></html>