<div dir="ltr">How many of these patches are applied in the 1.5 releases of GStreamer? We can upgrade instead and a colleague is going to be looking at the upgrades tomorrow, so if several can be dropped then that will save time and effort.<div><br></div><div>Ross</div></div><div class="gmail_extra"><br><div class="gmail_quote">On 27 July 2015 at 17:44, Otavio Salvador <span dir="ltr"><<a href="mailto:otavio.salvador@ossystems.com.br" target="_blank">otavio.salvador@ossystems.com.br</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello,<br>
<br>
I am fine with the patch but it needs fixing.<br>
<br>
Check below.<br>
<div><div class="h5"><br>
On Mon, Jul 27, 2015 at 8:26 AM, Yuqing Zhu <<a href="mailto:b54851@freescale.com">b54851@freescale.com</a>> wrote:<br>
> Use g_utf16_to_utf8() instead of g_convert to fix the issue that<br>
> id3 tags utf16 charaters cannot be extreacted in id3demux when try<br>
> to get the id3v2 tag such as TIT2, TALB etc.<br>
><br>
> Signed-off-by: Yuqing Zhu <<a href="mailto:b54851@freescale.com">b54851@freescale.com</a>><br>
> ---<br>
> .../fix-id3demux-utf16-to-utf8-issue.patch | 54 ++++++++++++++++++++++<br>
> .../gstreamer/<a href="http://gstreamer1.0-plugins-base_1.4.5.bb" rel="noreferrer" target="_blank">gstreamer1.0-plugins-base_1.4.5.bb</a> | 1 +<br>
> 2 files changed, 55 insertions(+)<br>
> create mode 100755 meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/fix-id3demux-utf16-to-utf8-issue.patch<br>
><br>
> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/fix-id3demux-utf16-to-utf8-issue.patch b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/fix-id3demux-utf16-to-utf8-issue.patch<br>
> new file mode 100755<br>
> index 0000000..458d153<br>
> --- /dev/null<br>
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/fix-id3demux-utf16-to-utf8-issue.patch<br>
> @@ -0,0 +1,54 @@<br>
> +Author: Lyon Wang <<a href="mailto:b12696@freescale.com">b12696@freescale.com</a>><br>
> +Date: Thu Oct 9 17:37:43 2014 +0800<br>
> +<br>
> +[id3v2frames] Bug fix for id3demux issue<br>
> +<br>
> +Fix the issue that id3 tags utf16 charaters cannot be extreacted in id3demux<br>
> +when I tried to get the id3v2 tag such as TIT2, TALB etc. it will return extrac<br>
> +failed.<br>
> +<br>
> +Checked in id3v2frame.c, When parse the UTF-16 streams, it used g_convert() to<br>
> +convert the buffer from UTF-16 to UTF-8, however it will return err that this<br>
> +conversion is not supported which cause the extraction failed with these UTF-16<br>
> +characters.<br>
> +<br>
> +In the patch, use g_utf16_to_utf8() instead of g_convert, which can convert the<br>
> +character format successfully.<br>
> +<br>
> +<a href="https://bugzilla.gnome.org/show_bug.cgi?id=741144" rel="noreferrer" target="_blank">https://bugzilla.gnome.org/show_bug.cgi?id=741144</a><br>
> +<br>
> +Upstream Status: Pending<br>
<br>
</div></div>It is:<br>
<br>
Upstream-Status:<br>
<br>
and it seems all patches you sent has this very same error. Please<br>
update it and resend the whole serie (with this fixed in ALL patches)<br>
as it is easy to get missed while applying the patches and makes<br>
tracking harder.<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
Otavio Salvador O.S. Systems<br>
<a href="http://www.ossystems.com.br" rel="noreferrer" target="_blank">http://www.ossystems.com.br</a> <a href="http://code.ossystems.com.br" rel="noreferrer" target="_blank">http://code.ossystems.com.br</a><br>
Mobile: <a href="tel:%2B55%20%2853%29%209981-7854" value="+555399817854">+55 (53) 9981-7854</a> Mobile: <a href="tel:%2B1%20%28347%29%20903-9750" value="+13479039750">+1 (347) 903-9750</a><br>
</font></span><div class="HOEnZb"><div class="h5">--<br>
_______________________________________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org">Openembedded-core@lists.openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
</div></div></blockquote></div><br></div>