<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Aug 22, 2015 at 11:50 AM, Andrea Adami <span dir="ltr"><<a href="mailto:andrea.adami@gmail.com" target="_blank">andrea.adami@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Sat, Aug 22, 2015 at 11:47 AM, Andrea Adami <span dir="ltr"><<a href="mailto:andrea.adami@gmail.com" target="_blank">andrea.adami@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span>On Sat, Aug 22, 2015 at 2:44 AM, Andre McCurdy <span dir="ltr"><<a href="mailto:armccurdy@gmail.com" target="_blank">armccurdy@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>On Fri, Aug 21, 2015 at 4:28 PM, Andrea Adami <<a href="mailto:andrea.adami@gmail.com" target="_blank">andrea.adami@gmail.com</a>> wrote:<br>
> After commit 24fde4d do_compile fails:<br>
><br>
> | mkfs.jffs2.c:70:21: fatal error: sys/acl.h: No such file or directory<br>
> | #include <sys/acl.h><br>
><br>
> Adding acl to the list of dependencies fixes the build.<br>
<br>
</span>Unconditionally enabling xattr and acl support is OK for the native<br>
build, but for the target both should probably be conditional on their<br>
respective DISTRO_FEATURES.<br></blockquote><div><br></div></span><div>I can agree, acl is one distro feature but atm it is not used by nodistro and poky.<br></div><div>So the patch unconditionally -DWITHOUT_XATTR seems wrong...this should be done only if acl is used.<span><font color="#888888"><br></font></span></div></div></div></div></blockquote><div><br><br></div></span><div>ofc I meant unconditionally removing -DWITHOUT_XATTR<br>( commit<a href="http://cgit.openembedded.org/openembedded-core/commit/meta/recipes-devtools/mtd/mtd-utils_git.bb?id=24fde4d983cc8f056177de6c1ad308369f6279ad" target="_blank">24fde4d983cc8f056177de6c1ad308369f6279ad )</a></div><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><span><font color="#888888"></font></span></div><span><font color="#888888"><div><br></div><div>Andrea<br></div></font></span><span><div><br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><div><br>
<br>
> Signed-off-by: Andrea Adami <<a href="mailto:andrea.adami@gmail.com" target="_blank">andrea.adami@gmail.com</a>><br>
> ---<br>
> meta/recipes-devtools/mtd/<a href="http://mtd-utils_git.bb" rel="noreferrer" target="_blank">mtd-utils_git.bb</a> | 2 +-<br>
> 1 file changed, 1 insertion(+), 1 deletion(-)<br>
><br>
> diff --git a/meta/recipes-devtools/mtd/<a href="http://mtd-utils_git.bb" rel="noreferrer" target="_blank">mtd-utils_git.bb</a> b/meta/recipes-devtools/mtd/<a href="http://mtd-utils_git.bb" rel="noreferrer" target="_blank">mtd-utils_git.bb</a><br>
> index 8d4892a..72ce9ed 100644<br>
> --- a/meta/recipes-devtools/mtd/<a href="http://mtd-utils_git.bb" rel="noreferrer" target="_blank">mtd-utils_git.bb</a><br>
> +++ b/meta/recipes-devtools/mtd/<a href="http://mtd-utils_git.bb" rel="noreferrer" target="_blank">mtd-utils_git.bb</a><br>
> @@ -5,7 +5,7 @@ LICENSE = "GPLv2+"<br>
> LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \<br>
> file://include/common.h;beginline=1;endline=17;md5=ba05b07912a44ea2bf81ce409380049c"<br>
><br>
> -DEPENDS = "zlib lzo e2fsprogs util-linux"<br>
> +DEPENDS = "zlib lzo e2fsprogs util-linux acl"<br>
><br>
> PV = "1.5.1+git${SRCPV}"<br>
><br>
> --<br>
> 1.9.1<br>
><br>
</div></div><span><font color="#888888">> --<br>
> _______________________________________________<br>
> Openembedded-core mailing list<br>
> <a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
> <a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
</font></span></blockquote></span></div><br></div></div>
</blockquote></span></div><br></div></div>
</blockquote></div><br></div><div class="gmail_extra">Please ignore, patch v2 will be sent now.<br></div><div class="gmail_extra">Cheers<br><br></div><div class="gmail_extra">Andrea<br></div><div class="gmail_extra"><br></div></div>