<div dir="ltr"><div><div><div><div>Patrick,<br><br></div>sorry I didn't put you in cc.<br></div>My quick&dirty workaround: <a href="http://patchwork.openembedded.org/patch/101169/">http://patchwork.openembedded.org/patch/101169/</a><br><br></div>Cheers<br><br></div>Andrea<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Aug 25, 2015 at 3:26 PM, Mark Hatle <span dir="ltr"><<a href="mailto:mark.hatle@windriver.com" target="_blank">mark.hatle@windriver.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On 8/25/15 6:46 AM, Patrick Ohly wrote:<br>
> On Fri, 2015-08-14 at 11:51 +0100, Burton, Ross wrote:<br>
>><br>
>> On 12 August 2015 at 10:33, Patrick Ohly <<a href="mailto:patrick.ohly@intel.com">patrick.ohly@intel.com</a>><br>
>> wrote:<br>
>> > There's a "xattr" DISTRO_FEATURE that should be respected<br>
>> here for<br>
>> > target builds (and explicitly enabled for native I guess).<br>
>><br>
>> I can add that check, if you want.<br>
>><br>
>> > Does enabling xattr mean adding build dependencies?<br>
>><br>
>> No, the conditional code uses lgetxattr and llistxattr, which<br>
>> are in<br>
>> glibc.<br>
>><br>
>><br>
>> From five seconds of google it looks like these are in musl and uclibc<br>
>> too, so I've merged this to MUT as-is.<br>
><br>
> However, it turned out that the XATTR code also introduces a dependency<br>
> on sys/acl.h:<br>
><br>
> mkfs.jffs2.c:<br>
><br>
> #ifndef WITHOUT_XATTR<br>
> #include <sys/xattr.h><br>
> #include <sys/acl.h><br>
> #endif<br>
><br>
> sys/acl.h gets provided by acl, so it may or may not work depending on<br>
> build order and files on the host.<br>
><br>
> I hadn't caught that because I had only looked at library dependencies,<br>
> sorry for that.<br>
><br>
> What's the right fix? Add the dependency on acl-native in the native<br>
> case, disable XATTR support for target builds (same state as before) or<br>
> make it somehow depend on both "xattr" and "acl" distro features?<br>
><br>
> Or only check for "xattr"? I'm uncertain how the two are related.<br>
><br>
<br>
</div></div>Use PACKAGECONFIG, add xattr as a configuration that in turn adds the 'acl' as a<br>
dependency. Then acl-native will automatically be converted from 'acl' if the<br>
'-native' version is built.<br>
<br>
This is typically how I've seen it implemented in other places. (Not necessary<br>
xattr.. but with the push for more Linux Security Models coming from users and<br>
other layers, I think xattr is something we need to make sure really works<br>
properly.)<br>
<span class="HOEnZb"><font color="#888888"><br>
--Mark<br>
</font></span><div class="HOEnZb"><div class="h5">--<br>
_______________________________________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org">Openembedded-core@lists.openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
</div></div></blockquote></div><br></div>