<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Aug 30, 2015 at 2:14 PM, Ed Bartosh <span dir="ltr"><<a href="mailto:ed.bartosh@linux.intel.com" target="_blank">ed.bartosh@linux.intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">Write set of bitbake variables used by wic into<br>
build/tmp/sysroots/<machine>/imagedata/<image>.env<br>
<br>
List of variables is defined in WICVARS variable in<br>
meta/classes/image_types.bbclass.<br>
<br>
This is needed for wic to be able to get bitbake variables without<br>
running 'bitbake -e'.<br>
<br>
Signed-off-by: Ed Bartosh <<a href="mailto:ed.bartosh@linux.intel.com">ed.bartosh@linux.intel.com</a>><br></span></blockquote><div><br></div><div>The function name (_write_env) sounds generic, as does the commit message, and the filename, yet it relies on a variable which is WIC-specific. This seems rather inconsistent to me, either this thing is for wic alone, or it isn't, and the function name, file name, and variable name should reflect that.</div></div>-- <br><div class="gmail_signature">Christopher Larson<br>clarson at kergoth dot com<br>Founder - BitBake, OpenEmbedded, OpenZaurus<br>Maintainer - Tslib<br>Senior Software Engineer, Mentor Graphics</div>
</div></div>