<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 10, 2015 at 5:18 PM, Martin Jansa <span dir="ltr"><<a href="mailto:martin.jansa@gmail.com" target="_blank">martin.jansa@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Thu, Sep 10, 2015 at 05:03:25PM +0300, Alexander Kanevskiy wrote:<br>
> On Wed, Sep 9, 2015 at 12:06 AM, Martin Jansa <<a href="mailto:martin.jansa@gmail.com">martin.jansa@gmail.com</a>><br>
> wrote:<br>> Gerrit, despite its good ability to integrate into existing infrastructures<br>
> might be not the best solution for OE, and I must admit, gerrit is not the<br>
> best tool in the world for reviews, as there are limits in it like missing<br>
<br>
</div></div>I disagree, we can agree on that :).<br>
<span class=""><br></span></blockquote><div><br></div><div>ok :)</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
> ability to review properly series of patches.<br>
<br>
</span>It allows to review series of patches very well, newer versions also<br>
show chains of reviews in better UI than older versions did.<br>
<br>
Worse problem is that such series need to be uploaded as series not as<br>
individual patches, because gerrit cannot automagically discover such<br>
dependencies between patches and cherry-pick them to single branch and<br>
resolve conflicts if there are, but if you push whole series of patches<br>
it will show it as chain and all works correctly.<br>
<span class=""><br></span></blockquote><div><br></div><div>might be. I haven't checked latest versions 2.10+, but versions below were not up to the shape compared to e.g. pull-request workflow in GitHub.</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
> However, for people who don't like Gerrit, there is also always a<br>
> possibility to use GitHub or something similar, like locally hosted GitLab<br>
> if OE don't want to be dependant on external service.<br>
<br>
</span>I want to use it to share status of the meta-oe patches with contributors,<br>
running my own GitLab locally won't help with this.<br>
<div class="HOEnZb"><div class="h5"><br></div></div></blockquote></div><div><br></div><div>GitHub's model is to fork repository, do any amount of modification in your own copy and then open "pull-request" for review where you just specify source/destination repositories and branches with set of changes.</div><div><br></div><div>Gitlab comment was practically to have similar to GitHub workflow, but instead of public's GitHub service to have instance on <a href="http://openembedded.org">openembedded.org</a> infrastructure, and thus requiring users to register accounts there.</div><div><br></div><div><br></div>-- <br><div class="gmail_signature">br, Alexander Kanevskiy</div>
</div></div>