<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Sep 22, 2015 at 1:45 PM, Marcus Müller <span dir="ltr"><<a href="mailto:marcus.mueller@ettus.com" target="_blank">marcus.mueller@ettus.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Hello,<br>
<span class="">> If I understand correctly it allows a user prepared $TEMPLATECONF<br>
> directory<br>
> to be used by oe-setup-builddir.<br>
</span>Indeed; the point is that oe-setup-builddir was definitely meant to be<br>
used with a TEMPLATECONF set by the user; in bash, the TEMPLATECONF<br>
local variable is automatically passed on from oe-init-build-env to<br>
oe-setup-builddir¹, but in zsh, this doesn't work without explicitely<br>
declaring that should happen (which is the only thing my patch does).<br>
<br>
Best regards,<br>
Marcus<br>
<br>
¹ not quite sure how; it's a local to the calling script and shouldn't<br>
be a local or env variable to the callee, IMHO.<br></blockquote><div><br></div><div><br></div><div>Hello Marcus,</div><div><br></div><div>FWIW, I did some test cases to understand the differences.</div><div><br></div><div>With bash 4.3.11, and the examples below,</div><div>cases A and B will pass along TEMPLATECONF, but case C does not.</div><div>Your patch makes case C work as well.</div><div><br></div><div># A:</div><div><br></div><div>TEMPLATECONF=$HOME/my-template-dir source ~/openembedded-core/oe-init-build-env $HOME/my-build-dir</div><div><br></div><div># B:</div><div>export TEMPLATECONF=$HOME/my-template-dir; source ~/openembedded-core/oe-init-build-env $HOME/my-build-dir</div><div><br></div><div># C:</div><div>TEMPLATECONF=$HOME/my-template-dir; source ~/openembedded-core/oe-init-build-env $HOME/my-build-dir</div><div><br></div><div><br></div><div>And with zsh 5.0.2, case B will pass along TEMPLATECONF, but cases A and C do not.</div><div>Your patch makes cases A and C work as well with zsh.</div><div><br></div><div>I did not expect case A to be different than case C for bash, but it apparently works differently than I thought.</div><div><br></div><div>Best regards,</div><div>Lee</div></div><br></div></div>