<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On 23 November 2015 at 02:38, Bian Naimeng <span dir="ltr"><<a href="mailto:biannm@cn.fujitsu.com" target="_blank">biannm@cn.fujitsu.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div id=":1ew" class="a3s" style="overflow:hidden"> /usr/lib/python2.7/site-packages/smart/transaction.py", line 1230, in run<br>
locked[pkg] = (LOCKED_KEEP, None)<br>
<br>
NameError: global name 'LOCKED_KEEP' is not defined<br>
<br>
Upstream-Status: Submitted [<a href="mailto:Smart@lists.labix.org">Smart@lists.labix.org</a>]<br></div></blockquote></div><br>The Upstream-Status tag should be in smart-define-LOCKED-KEEP.patch alongside the Signed-off-by, not the commit message. The intention is that the patch contains who wrote it and whether it's a backport, not suitable for upstream, and so on.</div><div class="gmail_extra"><br></div><div class="gmail_extra">Also the commit message should be in the traditional git shortlog/longlog form where the first line contains the recipe name and a brief summary, something like "python-smartpm: fix runtime errors by defining LOCKED_KEEP".</div><div class="gmail_extra"><br></div><div class="gmail_extra">Ross</div></div>