<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Dec 21, 2015 at 6:39 AM, Alexander Kanavin <span dir="ltr"><<a href="mailto:alexander.kanavin@linux.intel.com" target="_blank">alexander.kanavin@linux.intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 12/21/2015 01:27 PM, Otavio Salvador wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Commit logs are suppose to have the information useful to understand<br>
the reason of the change. Latest hides all behind it and does not<br>
communicate anything. I don't think expect people to read the code to<br>
know you bumped (and to which) revision is right.<br>
</blockquote>
<br></span>
Having the exact upstream commit id - a bunch of random numbers and letters - in the commit message does not make the commit message any more useful, readable, or searchable. You can't even click on that id to open a gitweb webpage with the upstream patch (having that kind of link *would* be useful though).<br>
<br>
The change to the recipe is short, and no one should be overwhelmed by looking at it if they need the commit id.<br></blockquote><div><br></div><div><br></div><div>We are of like minds on those points. It is more important to say why a change</div><div>was required, which is all that I look for in anything that I maintain.</div><div><br></div><div>That, and I'm always concerned that if someone contributes a patch that fixes</div><div>a real problem, or is part of a larger feature, and all they get are nit-pick comments</div><div>about more minor elements, it is a barrier to entry. Hence, why I'll also just</div><div>fix commit messages on the way into my queues if they need a tweak.</div><div><br></div><div>But I digress. I'll see if this passes autobuilder sanity, and if there's a chance,</div><div>I'll add a date to the log (but of course the commit also carries that info).</div><div><br></div><div>Cheers,</div><div><br></div><div>Bruce</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Alex<div class="HOEnZb"><div class="h5"><br>
-- <br>
_______________________________________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">"Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"</div>
</div></div>