<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jan 11, 2016 at 8:06 AM, Mark Hatle <span dir="ltr"><<a href="mailto:mark.hatle@windriver.com" target="_blank">mark.hatle@windriver.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 1/11/16 8:55 AM, Trevor Woerner wrote:<br>
><br>
><br>
> On 01/11/16 00:11, Robert Yang wrote:<br>
>> Avoid potential build path in output files.<br>
>><br>
>> [YOCTO #8894]<br>
>><br>
>> Signed-off-by: Robert Yang <<a href="mailto:liezhi.yang@windriver.com">liezhi.yang@windriver.com</a>><br>
>> ---<br>
>> meta/recipes-core/glibc/glibc-initial.inc | 2 +-<br>
>> 1 file changed, 1 insertion(+), 1 deletion(-)<br>
>><br>
>> diff --git a/meta/recipes-core/glibc/glibc-initial.inc b/meta/recipes-core/glibc/glibc-initial.inc<br>
>> index 8e81f09..cb2f8dd 100644<br>
>> --- a/meta/recipes-core/glibc/glibc-initial.inc<br>
>> +++ b/meta/recipes-core/glibc/glibc-initial.inc<br>
>> @@ -11,7 +11,7 @@ TOOLCHAIN_OPTIONS = " --sysroot=${STAGING_DIR_TCBOOTSTRAP}"<br>
>> do_configure () {<br>
>> (cd ${S} && gnu-configize) || die "failure in running gnu-configize"<br>
>> find ${S} -name "configure" | xargs touch<br>
>> - ${S}/configure --host=${TARGET_SYS} --build=${BUILD_SYS} \<br>
>> + ../git/configure --host=${TARGET_SYS} --build=${BUILD_SYS} \<br>
><br>
> Although I haven't tested it, this _looks_ like it might fail quite<br>
> readily. I'm sure there are some recipes that play tricks with ${S}, and<br>
> what about recipes that don't pull their sources from git?<br>
><br>
> Maybe something like: (cd ${S} && ./configure ...) would be better?<br>
<br>
</span>That won't work since it'll run configure in the S directory.<br>
<br>
IF we need to use relative paths here, we need to calculate the relative path<br>
from B to S and use that. It looks like patch 2/2 already does something like<br>
this using the python.. we can probably do the same. (I don't know any reason,<br>
at least for glibc, that all of the items won't be in the same "WORKDIR". So it<br>
would be relative within the WORKDIR, which SHOULD be fine.)</blockquote></div><br></div><div class="gmail_extra">Unless we want to specifically not support externalsrc (and therefore, devtool modify -x) for a particular recipe, we should probably not make the assumption that S and B are relative to WORKDIR :)<br>-- <br><div class="gmail_signature">Christopher Larson<br>clarson at kergoth dot com<br>Founder - BitBake, OpenEmbedded, OpenZaurus<br>Maintainer - Tslib<br>Senior Software Engineer, Mentor Graphics</div>
</div></div>