<div dir="ltr">Thanks for the advice Andreas, will do!<div><br>Nathan</div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, 8 Mar 2016 at 18:09 Andreas Oberritter <<a href="mailto:obi@opendreambox.org">obi@opendreambox.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello Nathan,<br>
<br>
On 08.03.2016 22:49, ngutzmann wrote:<br>
> The variable in question should have been called ecc->p. The patch has been updated<br>
> so that the compilation of the nettle recipe would complete successfully.<br>
><br>
> Signed-off-by: ngutzmann <<a href="mailto:nathangutzmann@gmail.com" target="_blank">nathangutzmann@gmail.com</a>><br>
> ---<br>
> meta/recipes-support/nettle/nettle-2.7.1/CVE-2015-8803_8805.patch | 2 +-<br>
> 1 file changed, 1 insertion(+), 1 deletion(-)<br>
><br>
> diff --git a/meta/recipes-support/nettle/nettle-2.7.1/CVE-2015-8803_8805.patch b/meta/recipes-support/nettle/nettle-2.7.1/CVE-2015-8803_8805.patch<br>
> index 1c4b9a9..a956f42 100644<br>
> --- a/meta/recipes-support/nettle/nettle-2.7.1/CVE-2015-8803_8805.patch<br>
> +++ b/meta/recipes-support/nettle/nettle-2.7.1/CVE-2015-8803_8805.patch<br>
> @@ -40,7 +40,7 @@ Index: nettle-2.7.1/ecc-256.c<br>
> u1 -= cy;<br>
> - u1 += cnd_add_n (t, rp + n - 4, ecc->p, 3);<br>
> +<br>
> -+ cy = cnd_add_n (t, rp + n - 4, p->m, 2);<br>
> ++ cy = cnd_add_n (t, rp + n - 4, ecc->p, 2);<br>
> + u0 += cy;<br>
> + u1 += (u0 < cy);<br>
> u1 -= (-t) & 0xffffffff;<br>
><br>
<br>
looks good to me. However, I needed to lookup the commit where the<br>
backport originated from, because the reason for exchanging m and p<br>
isn't obvious at all without knowing the original commit. Maybe you<br>
could include it in your commit message.<br>
<br>
<a href="https://git.lysator.liu.se/nettle/nettle/commit/c71d2c9d20eeebb985e3872e4550137209e3ce4d" rel="noreferrer" target="_blank">https://git.lysator.liu.se/nettle/nettle/commit/c71d2c9d20eeebb985e3872e4550137209e3ce4d</a><br>
<br>
Regards,<br>
Andreas<br>
--<br>
_______________________________________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
</blockquote></div>