<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 03/21/2016 10:47 PM, Burton, Ross
wrote:<br>
</div>
<blockquote
cite="mid:CAJTo0LbbXz4PkHzW97csmTBjnffFJwJnR6JauecLrXc-nH3_BQ@mail.gmail.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<div dir="ltr">
<div class="gmail_extra"><br>
<div class="gmail_quote">On 19 March 2016 at 14:56, Hongxu Jia
<span dir="ltr"><<a moz-do-not-send="true"
href="mailto:hongxu.jia@windriver.com" target="_blank">hongxu.jia@windriver.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div id=":9qh" class="a3s" style="overflow:hidden">+PACKAGECONFIG[debug]
= "--enable-debug=yes, --enable-debug=no"<br>
</div>
</blockquote>
</div>
<br>
There's an explicit --enable-debug in EXTRA_OECONF, </div>
</div>
</blockquote>
<br>
Yes, we should remove the duplicated --enable-debug in EXTRA_OECONF<br>
<br>
<blockquote
cite="mid:CAJTo0LbbXz4PkHzW97csmTBjnffFJwJnR6JauecLrXc-nH3_BQ@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">and reading the configure --help shows
that the "off" mode should be --enable-debug=minimum as "no"
removes the GLib checks which can result in crashes if bad
data is passed to the API.</div>
</div>
</blockquote>
<br>
./configure --help<br>
...<br>
--enable-debug Compile with debug checks.
[no/yes/minimum,<br>
default=minimum]<br>
...<br>
<br>
vim ./configure.ac<br>
...<br>
121 dnl Default to debug spew in unstable branch<br>
122 AC_ARG_ENABLE(debug,<br>
123 AS_HELP_STRING([--enable-debug],<br>
124 [Compile with debug checks. @<:@no/yes/minimum,
default=minimum@:>@]),<br>
125 , enable_debug=minimum)<br>
126 <br>
127 if test "x$enable_debug" = "xyes"; then<br>
128 CFLAGS="$CFLAGS -DGCONF_ENABLE_DEBUG=1"<br>
129 AC_MSG_NOTICE([Will build with debugging spew and checks])<br>
130 else<br>
131 if test "x$enable_debug" = "xno"; then<br>
132 CFLAGS="$CFLAGS -DG_DISABLE_CHECKS=1 -DG_DISABLE_ASSERT=1"<br>
133 AC_MSG_NOTICE([Will build without *any* debugging code])<br>
134 else<br>
135 AC_MSG_NOTICE([Will build with debug checks but no debug
spew])<br>
136 fi<br>
137 fi<br>
...<br>
<br>
vim gconf/gconfd.c<br>
...<br>
384 #ifdef GCONF_ENABLE_DEBUG<br>
385 /* -- Debug only */<br>
386 <br>
387 if (addresses == NULL)<br>
388 {<br>
389 gconf_log(GCL_DEBUG, _("gconfd compiled with debugging;
trying to load gconf.path from the source directory"));<br>
390 conffile = g_strconcat(GCONF_SRCDIR, "/gconf/gconf.path",
NULL);<br>
391 addresses = gconf_load_source_path(conffile, NULL);<br>
392 g_free(conffile);<br>
393 }<br>
394 <br>
395 /* -- End of Debug Only */<br>
396 #endif<br>
...<br>
<br>
If we could not use '--enable-debug=yes' to fix build paths issue,<br>
and as your suggested it should not remove check and assert,<br>
so minimum is the best choice.<br>
<br>
//Hongxu<br>
<br>
<blockquote
cite="mid:CAJTo0LbbXz4PkHzW97csmTBjnffFJwJnR6JauecLrXc-nH3_BQ@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra"><br>
</div>
<div class="gmail_extra">Ross</div>
</div>
</blockquote>
<br>
</body>
</html>