<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Apr 18, 2016 at 10:45 PM, Robert Yang <span dir="ltr"><<a href="mailto:liezhi.yang@windriver.com" target="_blank">liezhi.yang@windriver.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Before this patch, we need two steps to create PULL:<br>
* Step 1, create branch:<br>
$ git push <contrib> <local_branch>:<remote_branch><br>
* Step 2, create PULL:<br>
$ create-pull-request -u <contrib> -l <local_branch> -b <remote_branch> -r <local_branch>~<n><br>
<br>
We can see that the args used in step 1 are in step 2, so we can use<br>
create-pull-request to create the branch if not found to simplify the<br>
steps.<br></blockquote><div><br></div><div>I think this needs to be optional. When I'm running this script, I'm just looking to have something</div><div>I've already pushed locally dumped. If I mess up, and don't have the branch that I've used</div><div>pushed to my remote already (or for whatever reason want/need different branches .. which</div><div>was broken in previous updates to the script .. grrr), I don't want something pushing a branch</div><div>without be explicitly giving permission for that to happen.</div><div><br></div><div>Bruce</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
[YOCTO #9408]<br>
<br>
Signed-off-by: Robert Yang <<a href="mailto:liezhi.yang@windriver.com">liezhi.yang@windriver.com</a>><br>
---<br>
scripts/create-pull-request | 4 ++--<br>
1 file changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/scripts/create-pull-request b/scripts/create-pull-request<br>
index 479ad6e..7dc9836 100755<br>
--- a/scripts/create-pull-request<br>
+++ b/scripts/create-pull-request<br>
@@ -173,8 +173,8 @@ esac<br>
if [ -n "$WEB_URL" ]; then<br>
wget --no-check-certificate -q $WEB_URL -O /dev/null<br>
if [ $? -ne 0 ]; then<br>
- echo "WARNING: Branch '$BRANCH' was not found on the contrib git tree."<br>
- echo " Please check your remote and branch parameter before sending."<br>
+ echo "Branch '$BRANCH' not found on '$REMOTE', creating it..."<br>
+ git push $REMOTE $L_BRANCH:$BRANCH<br>
echo ""<br>
fi<br>
fi<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.7.4<br>
<br>
--<br>
_______________________________________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org">Openembedded-core@lists.openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">"Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"</div>
</div></div>