<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Apr 26, 2016 at 12:49 PM, Peter Kjellerstedt <span dir="ltr"><<a href="mailto:peter.kjellerstedt@axis.com" target="_blank">peter.kjellerstedt@axis.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The functions base_detect_revision() and base_detect_branch() try to<br>
extract SCM meta information from the path returned by<br>
base_get_scmbasepath(), which currently returns ${COREBASE}. However,<br>
making the assumption that ${COREBASE} contains SCM meta information<br>
can be false. It is true for Poky, but not necessarily other<br>
environments. A better option is to look for the SCM meta information<br>
based on the meta layer.<br>
<br>
Signed-off-by: Peter Kjellerstedt <<a href="mailto:peter.kjellerstedt@axis.com">peter.kjellerstedt@axis.com</a>><br>
---<br>
meta/classes/metadata_scm.bbclass | 5 ++---<br>
1 file changed, 2 insertions(+), 3 deletions(-)<br>
<br>
diff --git a/meta/classes/metadata_scm.bbclass b/meta/classes/metadata_scm.bbclass<br>
index 0f7f423..2e6fac2 100644<br>
--- a/meta/classes/metadata_scm.bbclass<br>
+++ b/meta/classes/metadata_scm.bbclass<br>
@@ -4,8 +4,7 @@ METADATA_REVISION ?= "${@base_detect_revision(d)}"<br>
def base_detect_revision(d):<br>
path = base_get_scmbasepath(d)<br>
<br>
- scms = [base_get_metadata_git_revision, \<br>
- base_get_metadata_svn_revision]<br>
+ scms = [base_get_metadata_git_revision]<br></blockquote><div><br></div><div>Was this change intended? Because it doesn't match up with the commit message, as far as I can see.</div></div>-- <br><div class="gmail_signature">Christopher Larson<br>clarson at kergoth dot com<br>Founder - BitBake, OpenEmbedded, OpenZaurus<br>Maintainer - Tslib<br>Senior Software Engineer, Mentor Graphics</div>
</div></div>