<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, May 4, 2016 at 7:01 AM, Ed Bartosh <span dir="ltr"><<a href="mailto:ed.bartosh@linux.intel.com" target="_blank">ed.bartosh@linux.intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Tue, May 03, 2016 at 07:33:58PM +0000, Christopher Larson wrote:<br>
> On Tue, May 3, 2016 at 7:31 PM, Christopher Larson <<a href="mailto:clarson@kergoth.com">clarson@kergoth.com</a>><br>
> wrote:<br>
><br>
> ><br>
> ><br>
> > On Mon, May 2, 2016 at 12:22 PM, Ed Bartosh <<a href="mailto:ed.bartosh@linux.intel.com">ed.bartosh@linux.intel.com</a>><br>
> > wrote:<br>
> ><br>
> >> Generated standalone bmaptool script that is more convenient<br>
> >> to use than native script. It can be run straight from<br>
> >> its location ./tmp/deploy/tools/bmaptool. The script doesn't<br>
> >> depend on anything except Python.<br>
> >><br>
> >> Signed-off-by: Ed Bartosh <<a href="mailto:ed.bartosh@linux.intel.com">ed.bartosh@linux.intel.com</a>><br>
> >><br>
> ><br>
> > You're right that this is very handy, but we hit a problem when building<br>
> > from shared state. This uses do_deploy to deploy bmaptool into<br>
> > DEPLOY_DIR_IMAGE, but IMAGE_DEPENDS only depends on do_populate_sysroot,<br>
> > not do_deploy, so an image build from sstate won't write this script out.<br>
> ><br>
> > I don't know the right way to fix this, but it's a problem. I just ran<br>
> > into it :)<br>
> ><br>
><br>
> Also, the convention is to add do_deploy before do_build, not before<br>
> do_package, otherwise do_deploy's checksum is included int he checksums of<br>
> do_package and subsequent tasks, even though its output isn't used by any<br>
> subsequent tasks.<br>
<br>
</span>I also found this a bit unusual to put the tool into deploy/tools.<br>
That's why I isolated this change. I think it requires some more<br>
testing, but the rest of patchset can be accepted without it.</blockquote></div><br>Yeah, putting it there does require some discussion in general. Personally, I'm in favor of such a thing, because we don't want to put generated convenience tools in the sysroot, since we tell people explicitly to not use sysroot contents directly.<br><br clear="all"><div>Regarding getting it built for the image, I'd suggest adding something like IMAGE_TASKDEPENDS to image_type.bbclass, which is basically like IMAGE_DEPENDS, but with the task included. I.e. IMAGE_TASKDEPENDS_bmap = "bmap-tools-native:do_deploy". Then you wouldn't need the 'before do_package', and it'd fix the from-sstate usage.</div>-- <br><div class="gmail_signature">Christopher Larson<br>clarson at kergoth dot com<br>Founder - BitBake, OpenEmbedded, OpenZaurus<br>Maintainer - Tslib<br>Senior Software Engineer, Mentor Graphics</div>
</div></div>