<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, May 9, 2016 at 12:43 AM, Paul Eggleton <span dir="ltr"><<a href="mailto:paul.eggleton@linux.intel.com" target="_blank">paul.eggleton@linux.intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Add the capability for other recipes to verify that kernel<br>
configuration options they depend upon at runtime are present, and warn<br>
if they are missing. This seems functional enough to me but is still in<br>
RFC - please let me know if it looks OK to you or I've missed anything<br>
(no doubt there are recipes we could add the checks to, I refer mainly<br>
to the mechanism itself).<br>
<br>
<br>
Please review the following changes for suitability for inclusion. If you have<br>
any objections or suggestions for improvement, please respond to the patches. If<br>
you agree with the changes, please provide your Acked-by.<br>
<br></blockquote><div><br></div><div>See my replies to the patches. I'm sure it won't matter in the end, but this is a duplication</div><div>of the mechanisms that we already have in the kernel config check phase. I have a whole</div><div>set of changes that I completed early this year that extends that mechanism to any kernel</div><div>(not just kernel-yocto) classes. In that mechanism there's the concept of "required" and</div><div>"optional" Kconfig options. If they aren't present in the final .config, we warn and optionally</div><div>error (this is versus the currently mechanism of only warning if boot critical options are</div><div>dropped).</div><div><br></div><div>I'm betting that the follow on to this series will be "Hey recipes should set the options for the kernel if</div><div>they really need them" .. which IMHO is an incredibly bad idea.</div><div><br></div><div>Cheers,</div><div><br></div><div>Bruce</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
The following changes since commit ece101be5158beee709cdfbb85ecdbdc8d9fb864:<br>
<br>
test-empty-image: Fix LIC_FILES_CHKSUM typo (2016-05-06 10:47:59 +0100)<br>
<br>
are available in the git repository at:<br>
<br>
git://<a href="http://git.openembedded.org/openembedded-core-contrib" rel="noreferrer" target="_blank">git.openembedded.org/openembedded-core-contrib</a> paule/kernel-check<br>
<a href="http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/kernel-check" rel="noreferrer" target="_blank">http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/kernel-check</a><br>
<br>
Paul Eggleton (6):<br>
classes/kernel-check: add a class to check kernel config options<br>
eudev: check for required kernel config options<br>
systemd: check for required kernel config options<br>
classes/kernel: fix typo<br>
classes/kernel: check OLDEST_KERNEL at configure time<br>
classes/image: check kernel config supports IMAGE_FSTYPES items<br>
<br>
meta/classes/image.bbclass | 23 ++++++++<br>
meta/classes/image_types.bbclass | 11 ++++<br>
meta/classes/kernel-check.bbclass | 97 ++++++++++++++++++++++++++++++++<br>
meta/classes/kernel.bbclass | 16 +++++-<br>
meta/recipes-core/systemd/<a href="http://systemd_229.bb" rel="noreferrer" target="_blank">systemd_229.bb</a> | 19 ++++++-<br>
meta/recipes-core/udev/<a href="http://eudev_3.1.5.bb" rel="noreferrer" target="_blank">eudev_3.1.5.bb</a> | 22 +++++++-<br>
6 files changed, 185 insertions(+), 3 deletions(-)<br>
create mode 100644 meta/classes/kernel-check.bbclass<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
2.5.5<br>
<br>
--<br>
_______________________________________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org">Openembedded-core@lists.openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">"Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"</div>
</div></div>