<p dir="ltr">Yes</p>
<div class="gmail_quote">On May 10, 2016 6:08 AM, "Robert Yang" <<a href="mailto:liezhi.yang@windriver.com">liezhi.yang@windriver.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
Hi Khem,<br>
<br>
What did you mean, please ? I assume ok to backport ?<br>
<br>
// Robert<br>
<br>
On 04/30/2016 04:47 AM, Khem Raj wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
this is ok to install.<br>
<br>
On Wed, Apr 27, 2016 at 2:39 PM, Tristan Van Berkom<br>
<<a href="mailto:tristan.vanberkom@codethink.co.uk" target="_blank">tristan.vanberkom@codethink.co.uk</a>> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
We fail to build webkit on aarch64 due to this binutils bug:<br>
<br>
<a href="https://sourceware.org/bugzilla/show_bug.cgi?id=19353" rel="noreferrer" target="_blank">https://sourceware.org/bugzilla/show_bug.cgi?id=19353</a><br>
<br>
Applying patch which fixes this, stripped out changelog entry<br>
from patch to make it apply without error.<br>
---<br>
meta/recipes-devtools/binutils/binutils-2.25.1.inc | 1 +<br>
...plying-TLSDESC-relocs-without-TLS-segment.patch | 166 +++++++++++++++++++++<br>
2 files changed, 167 insertions(+)<br>
create mode 100644 meta/recipes-devtools/binutils/binutils/fix-internal-error-when-applying-TLSDESC-relocs-without-TLS-segment.patch<br>
<br>
diff --git a/meta/recipes-devtools/binutils/binutils-2.25.1.inc b/meta/recipes-devtools/binutils/binutils-2.25.1.inc<br>
index f3817fa..c7db9e0 100644<br>
--- a/meta/recipes-devtools/binutils/binutils-2.25.1.inc<br>
+++ b/meta/recipes-devtools/binutils/binutils-2.25.1.inc<br>
@@ -35,6 +35,7 @@ SRC_URI = "\<br>
file://0015-Fix-dynamic-list-so-that-symbols-not-in-the-list-are.patch \<br>
file://binutils-octeon3.patch \<br>
file://add-thunderx-support-for-gas.patch \<br>
+ file://fix-internal-error-when-applying-TLSDESC-relocs-without-TLS-segment.patch \<br>
"<br>
S = "${WORKDIR}/git"<br>
<br>
diff --git a/meta/recipes-devtools/binutils/binutils/fix-internal-error-when-applying-TLSDESC-relocs-without-TLS-segment.patch b/meta/recipes-devtools/binutils/binutils/fix-internal-error-when-applying-TLSDESC-relocs-without-TLS-segment.patch<br>
new file mode 100644<br>
index 0000000..df9d54c<br>
--- /dev/null<br>
+++ b/meta/recipes-devtools/binutils/binutils/fix-internal-error-when-applying-TLSDESC-relocs-without-TLS-segment.patch<br>
@@ -0,0 +1,166 @@<br>
+From d21f123b0ead1806416cf0dafae12bec4cca8920 Mon Sep 17 00:00:00 2001<br>
+From: Cary Coutant <<a href="mailto:ccoutant@gmail.com" target="_blank">ccoutant@gmail.com</a>><br>
+Date: Mon, 11 Jan 2016 23:57:44 -0800<br>
+Subject: [PATCH] Fix internal error when applying TLSDESC relocations with no TLS segment.<br>
+<br>
+gold/<br>
+ PR gold/19353<br>
+ * aarch64.cc (Target_aarch64::relocate_tls): Don't insist that<br>
+ we have a TLS segment for GD-to-IE optimization.<br>
+ * i386.cc (Target_i386::tls_gd_to_ie): Remove tls_segment parameter.<br>
+ Adjust all calls.<br>
+ (Target_i386::tls_desc_gd_to_ie): Likewise.<br>
+ (Target_i386::relocate_tls): Don't insist that we have a TLS segment<br>
+ for TLSDESC GD-to-IE optimizations.<br>
+ * x86_64.cc (Target_x86_64::tls_gd_to_ie): Remove tls_segment parameter.<br>
+ Adjust all calls.<br>
+ (Target_x86_64::tls_desc_gd_to_ie): Likewise.<br>
+ (Target_x86_64::relocate_tls): Don't insist that we have a TLS segment<br>
+ for TLSDESC GD-to-IE optimizations.<br>
+---<br>
+ gold/aarch64.cc | 6 ------<br>
+ gold/i386.cc | 14 ++------------<br>
+ gold/x86_64.cc | 14 ++------------<br>
+ 4 files changed, 20 insertions(+), 30 deletions(-)<br>
+<br>
+diff --git a/gold/aarch64.cc b/gold/aarch64.cc<br>
+index 20f2f4f..5ad061b 100644<br>
+--- a/gold/aarch64.cc<br>
++++ b/gold/aarch64.cc<br>
+@@ -7422,12 +7422,6 @@ Target_aarch64<size, big_endian>::Relocate::relocate_tls(<br>
+ }<br>
+ if (tlsopt == tls::TLSOPT_TO_IE)<br>
+ {<br>
+- if (tls_segment == NULL)<br>
+- {<br>
+- gold_assert(parameters->errors()->error_count() > 0<br>
+- || issue_undefined_symbol_error(gsym));<br>
+- return aarch64_reloc_funcs::STATUS_BAD_RELOC;<br>
+- }<br>
+ return tls_desc_gd_to_ie(relinfo, target, rela, r_type,<br>
+ view, psymval, got_entry_address,<br>
+ address);<br>
+diff --git a/gold/i386.cc b/gold/i386.cc<br>
+index 82886d4..a7168a8 100644<br>
+--- a/gold/i386.cc<br>
++++ b/gold/i386.cc<br>
+@@ -668,7 +668,6 @@ class Target_i386 : public Sized_target<32, false><br>
+ // Do a TLS General-Dynamic to Initial-Exec transition.<br>
+ inline void<br>
+ tls_gd_to_ie(const Relocate_info<32, false>*, size_t relnum,<br>
+- Output_segment* tls_segment,<br>
+ const elfcpp::Rel<32, false>&, unsigned int r_type,<br>
+ elfcpp::Elf_types<32>::Elf_Addr value,<br>
+ unsigned char* view,<br>
+@@ -687,7 +686,6 @@ class Target_i386 : public Sized_target<32, false><br>
+ // transition.<br>
+ inline void<br>
+ tls_desc_gd_to_ie(const Relocate_info<32, false>*, size_t relnum,<br>
+- Output_segment* tls_segment,<br>
+ const elfcpp::Rel<32, false>&, unsigned int r_type,<br>
+ elfcpp::Elf_types<32>::Elf_Addr value,<br>
+ unsigned char* view,<br>
+@@ -3054,7 +3052,7 @@ Target_i386::Relocate::relocate_tls(const Relocate_info<32, false>* relinfo,<br>
+ }<br>
+ if (optimized_type == tls::TLSOPT_TO_IE)<br>
+ {<br>
+- this->tls_gd_to_ie(relinfo, relnum, tls_segment, rel, r_type,<br>
++ this->tls_gd_to_ie(relinfo, relnum, rel, r_type,<br>
+ got_offset, view, view_size);<br>
+ break;<br>
+ }<br>
+@@ -3116,13 +3114,7 @@ Target_i386::Relocate::relocate_tls(const Relocate_info<32, false>* relinfo,<br>
+ }<br>
+ if (optimized_type == tls::TLSOPT_TO_IE)<br>
+ {<br>
+- if (tls_segment == NULL)<br>
+- {<br>
+- gold_assert(parameters->errors()->error_count() > 0<br>
+- || issue_undefined_symbol_error(gsym));<br>
+- return;<br>
+- }<br>
+- this->tls_desc_gd_to_ie(relinfo, relnum, tls_segment, rel, r_type,<br>
++ this->tls_desc_gd_to_ie(relinfo, relnum, rel, r_type,<br>
+ got_offset, view, view_size);<br>
+ break;<br>
+ }<br>
+@@ -3354,7 +3346,6 @@ Target_i386::Relocate::tls_gd_to_le(const Relocate_info<32, false>* relinfo,<br>
+ inline void<br>
+ Target_i386::Relocate::tls_gd_to_ie(const Relocate_info<32, false>* relinfo,<br>
+ size_t relnum,<br>
+- Output_segment*,<br>
+ const elfcpp::Rel<32, false>& rel,<br>
+ unsigned int,<br>
+ elfcpp::Elf_types<32>::Elf_Addr value,<br>
+@@ -3449,7 +3440,6 @@ inline void<br>
+ Target_i386::Relocate::tls_desc_gd_to_ie(<br>
+ const Relocate_info<32, false>* relinfo,<br>
+ size_t relnum,<br>
+- Output_segment*,<br>
+ const elfcpp::Rel<32, false>& rel,<br>
+ unsigned int r_type,<br>
+ elfcpp::Elf_types<32>::Elf_Addr value,<br>
+diff --git a/gold/x86_64.cc b/gold/x86_64.cc<br>
+index 3cfc064..4ad5afc 100644<br>
+--- a/gold/x86_64.cc<br>
++++ b/gold/x86_64.cc<br>
+@@ -816,7 +816,6 @@ class Target_x86_64 : public Sized_target<size, false><br>
+ // Do a TLS General-Dynamic to Initial-Exec transition.<br>
+ inline void<br>
+ tls_gd_to_ie(const Relocate_info<size, false>*, size_t relnum,<br>
+- Output_segment* tls_segment,<br>
+ const elfcpp::Rela<size, false>&, unsigned int r_type,<br>
+ typename elfcpp::Elf_types<size>::Elf_Addr value,<br>
+ unsigned char* view,<br>
+@@ -835,7 +834,6 @@ class Target_x86_64 : public Sized_target<size, false><br>
+ // Do a TLSDESC-style General-Dynamic to Initial-Exec transition.<br>
+ inline void<br>
+ tls_desc_gd_to_ie(const Relocate_info<size, false>*, size_t relnum,<br>
+- Output_segment* tls_segment,<br>
+ const elfcpp::Rela<size, false>&, unsigned int r_type,<br>
+ typename elfcpp::Elf_types<size>::Elf_Addr value,<br>
+ unsigned char* view,<br>
+@@ -3733,7 +3731,7 @@ Target_x86_64<size>::Relocate::relocate_tls(<br>
+ if (optimized_type == tls::TLSOPT_TO_IE)<br>
+ {<br>
+ value = target->got_plt_section()->address() + got_offset;<br>
+- this->tls_gd_to_ie(relinfo, relnum, tls_segment, rela, r_type,<br>
++ this->tls_gd_to_ie(relinfo, relnum, rela, r_type,<br>
+ value, view, address, view_size);<br>
+ break;<br>
+ }<br>
+@@ -3800,14 +3798,8 @@ Target_x86_64<size>::Relocate::relocate_tls(<br>
+ }<br>
+ if (optimized_type == tls::TLSOPT_TO_IE)<br>
+ {<br>
+- if (tls_segment == NULL)<br>
+- {<br>
+- gold_assert(parameters->errors()->error_count() > 0<br>
+- || issue_undefined_symbol_error(gsym));<br>
+- return;<br>
+- }<br>
+ value = target->got_plt_section()->address() + got_offset;<br>
+- this->tls_desc_gd_to_ie(relinfo, relnum, tls_segment,<br>
++ this->tls_desc_gd_to_ie(relinfo, relnum,<br>
+ rela, r_type, value, view, address,<br>
+ view_size);<br>
+ break;<br>
+@@ -3973,7 +3965,6 @@ inline void<br>
+ Target_x86_64<size>::Relocate::tls_gd_to_ie(<br>
+ const Relocate_info<size, false>* relinfo,<br>
+ size_t relnum,<br>
+- Output_segment*,<br>
+ const elfcpp::Rela<size, false>& rela,<br>
+ unsigned int,<br>
+ typename elfcpp::Elf_types<size>::Elf_Addr value,<br>
+@@ -4085,7 +4076,6 @@ inline void<br>
+ Target_x86_64<size>::Relocate::tls_desc_gd_to_ie(<br>
+ const Relocate_info<size, false>* relinfo,<br>
+ size_t relnum,<br>
+- Output_segment*,<br>
+ const elfcpp::Rela<size, false>& rela,<br>
+ unsigned int r_type,<br>
+ typename elfcpp::Elf_types<size>::Elf_Addr value,<br>
+--<br>
+1.7.1<br>
+<br>
--<br>
2.8.0.rc3<br>
<br>
--<br>
_______________________________________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
</blockquote></blockquote>
</blockquote></div>