<div dir="ltr">I am getting these errors with clang now<div><br></div><div><a href="http://errors.yoctoproject.org/Errors/Details/64935/">http://errors.yoctoproject.org/Errors/Details/64935/</a><br></div></div><br><div class="gmail_quote"><div dir="ltr">On Fri, May 20, 2016 at 8:04 PM Christopher Larson <<a href="mailto:kergoth@gmail.com">kergoth@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Christopher Larson <<a href="mailto:chris_larson@mentor.com" target="_blank">chris_larson@mentor.com</a>><br>
<br>
We weren't consistent in the HOST_ (aka BUILD_) and non-HOST_ flags, so we<br>
were using BUILD_CPPFLAGS to compile target stuff, for example. Sort that out,<br>
and make sure we obey LDFLAGS.<br>
<br>
Signed-off-by: Christopher Larson <<a href="mailto:chris_larson@mentor.com" target="_blank">chris_larson@mentor.com</a>><br>
---<br>
<br>
v2 change: fixed patch file paths<br>
<br>
.../mkelfimage/mkelfimage/cross-compile.patch | 85 +++++++++++++++-------<br>
meta/recipes-devtools/mkelfimage/<a href="http://mkelfimage_git.bb" rel="noreferrer" target="_blank">mkelfimage_git.bb</a> | 4 +-<br>
2 files changed, 62 insertions(+), 27 deletions(-)<br>
<br>
diff --git a/meta/recipes-devtools/mkelfimage/mkelfimage/cross-compile.patch b/meta/recipes-devtools/mkelfimage/mkelfimage/cross-compile.patch<br>
index 7692709..2ae9fb5 100644<br>
--- a/meta/recipes-devtools/mkelfimage/mkelfimage/cross-compile.patch<br>
+++ b/meta/recipes-devtools/mkelfimage/mkelfimage/cross-compile.patch<br>
@@ -1,13 +1,43 @@<br>
-make the tool to be cross compilable.<br>
+From dc2712119d6832e24a9b7bed9ed4ce5ae03ce0a3 Mon Sep 17 00:00:00 2001<br>
+From: Khem Raj <<a href="mailto:raj.khem@gmail.com" target="_blank">raj.khem@gmail.com</a>><br>
+Date: Sat, 14 Jul 2012 14:14:07 -0700<br>
+Subject: [PATCH] mkelfimage: Fix cross build<br>
+<br>
+Make the tool to be cross compilable, by separating the variables for build<br>
+tools from those for the target. Also modified to obey LDFLAGS.<br>
<br>
Signed-off-by: Khem Raj <<a href="mailto:raj.khem@gmail.com" target="_blank">raj.khem@gmail.com</a>><br>
+Signed-off-by: Christopher Larson <<a href="mailto:chris_larson@mentor.com" target="_blank">chris_larson@mentor.com</a>><br>
+<br>
Upstream-Status: Pending<br>
<br>
-Index: mkelfImage/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br>
-===================================================================<br>
---- mkelfImage.orig/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a> 2012-07-14 14:04:48.964898667 -0700<br>
-+++ mkelfImage/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a> 2012-07-14 14:10:47.800916083 -0700<br>
-@@ -70,6 +70,9 @@<br>
+---<br>
+ <a href="http://Makefile.conf.in" rel="noreferrer" target="_blank">Makefile.conf.in</a> | 3 +++<br>
+ <a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a> | 7 +++++--<br>
+ linux-i386/Makefile | 2 +-<br>
+ linux-ia64/Makefile | 2 +-<br>
+ main/Makefile | 4 ++--<br>
+ 5 files changed, 12 insertions(+), 6 deletions(-)<br>
+<br>
+diff --git a/<a href="http://Makefile.conf.in" rel="noreferrer" target="_blank">Makefile.conf.in</a> b/<a href="http://Makefile.conf.in" rel="noreferrer" target="_blank">Makefile.conf.in</a><br>
+index 4645e44..dcb6cf2 100644<br>
+--- a/<a href="http://Makefile.conf.in" rel="noreferrer" target="_blank">Makefile.conf.in</a><br>
++++ b/<a href="http://Makefile.conf.in" rel="noreferrer" target="_blank">Makefile.conf.in</a><br>
+@@ -17,6 +17,9 @@ DEFS=@DEFS@<br>
+ LIBS=@LIBS@<br>
+ HOST_CC=@HOST_CC@<br>
+ HOST_CFLAGS=@HOST_CFLAGS@ $(DEFS)<br>
++CC=@CC@<br>
++CFLAGS=@CFLAGS@ $(DEFS)<br>
++LDFLAGS=@LDFLAGS@<br>
+<br>
+ I386_CC =@I386_CC@<br>
+ I386_LD =@I386_LD@<br>
+diff --git a/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a> b/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br>
+index 652b952..0f2ac72 100644<br>
+--- a/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br>
++++ b/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br>
+@@ -70,6 +70,9 @@ if test "with_default" != no ; then<br>
AC_MSG_ERROR([cc not found])<br>
fi<br>
eval "${with_default}_CC='$CC'"<br>
@@ -17,19 +47,22 @@ Index: mkelfImage/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br>
AC_PROG_CPP<br>
if test "$CPP" = no; then<br>
AC_MSG_ERROR([cpp not found])<br>
-@@ -172,7 +175,6 @@<br>
+@@ -172,8 +175,8 @@ fi<br>
<br>
dnl ---Output variables...<br>
<br>
-HOST_CC=$CC<br>
- HOST_CFLAGS="$HOST_CFLAGS -O2 -Wall \$(HOST_CPPFLAGS)"<br>
+-HOST_CFLAGS="$HOST_CFLAGS -O2 -Wall \$(HOST_CPPFLAGS)"<br>
++CFLAGS="${CFLAGS:--O2} -Wall \$(CPPFLAGS)"<br>
++HOST_CFLAGS="${HOST_CFLAGS:--O2} -Wall \$(HOST_CPPFLAGS)"<br>
<br>
dnl TODO: figure out how to set these appropriately for compilers other than gcc<br>
-Index: mkelfImage/linux-i386/Makefile<br>
-===================================================================<br>
---- mkelfImage.orig/linux-i386/Makefile 2012-07-14 14:04:48.964898667 -0700<br>
-+++ mkelfImage/linux-i386/Makefile 2012-07-14 14:04:49.032898671 -0700<br>
-@@ -4,7 +4,7 @@<br>
+ I386_CFLAGS="$I386_CFLAGS -Os -ffreestanding -Wall -W -Wno-format \$(I386_CPPFLAGS)"<br>
+diff --git a/linux-i386/Makefile b/linux-i386/Makefile<br>
+index 51531d6..7e8aa3c 100644<br>
+--- a/linux-i386/Makefile<br>
++++ b/linux-i386/Makefile<br>
+@@ -4,7 +4,7 @@ LI386_DEP=Makefile Makefile.conf $(LI386_DIR)/Makefile<br>
<br>
$(LI386_OBJ)/mkelf-linux-i386.o: $(LI386_DIR)/mkelf-linux-i386.c $(LI386_DIR)/convert.bin.c $(LI386_DEP)<br>
$(MKDIR) -p $(@D)<br>
@@ -38,11 +71,11 @@ Index: mkelfImage/linux-i386/Makefile<br>
<br>
<br>
ifdef I386_CC<br>
-Index: mkelfImage/linux-ia64/Makefile<br>
-===================================================================<br>
---- mkelfImage.orig/linux-ia64/Makefile 2012-07-14 14:04:48.964898667 -0700<br>
-+++ mkelfImage/linux-ia64/Makefile 2012-07-14 14:04:49.032898671 -0700<br>
-@@ -4,7 +4,7 @@<br>
+diff --git a/linux-ia64/Makefile b/linux-ia64/Makefile<br>
+index 38f5d8c..5df8870 100644<br>
+--- a/linux-ia64/Makefile<br>
++++ b/linux-ia64/Makefile<br>
+@@ -4,7 +4,7 @@ LIA64_DEP=Makefile Makefile.conf $(LIA64_DIR)/Makefile<br>
<br>
$(LIA64_OBJ)/mkelf-linux-ia64.o: $(LIA64_DIR)/mkelf-linux-ia64.c $(LIA64_DIR)/convert.bin.c $(LIA64_DEP)<br>
$(MKDIR) -p $(@D)<br>
@@ -51,21 +84,23 @@ Index: mkelfImage/linux-ia64/Makefile<br>
<br>
ifdef IA64_CC<br>
<br>
-Index: mkelfImage/main/Makefile<br>
-===================================================================<br>
---- mkelfImage.orig/main/Makefile 2012-07-14 14:04:48.964898667 -0700<br>
-+++ mkelfImage/main/Makefile 2012-07-14 14:04:49.032898671 -0700<br>
-@@ -4,11 +4,11 @@<br>
+diff --git a/main/Makefile b/main/Makefile<br>
+index 403b0a4..cd53613 100644<br>
+--- a/main/Makefile<br>
++++ b/main/Makefile<br>
+@@ -4,11 +4,11 @@ MKELF_OBJS=$(OBJDIR)/main/mkelfImage.o \<br>
<br>
$(OBJDIR)/sbin/mkelfImage: $(MKELF_OBJS) $(DEPS)<br>
$(MKDIR) -p $(@D)<br>
- $(HOST_CC) $(HOST_CFLAGS) $(MKELF_OBJS) -o $@ $(LIBS)<br>
-+ $(CC) $(HOST_CFLAGS) $(MKELF_OBJS) -o $@ $(LIBS)<br>
++ $(CC) $(CFLAGS) $(LDFLAGS) $(MKELF_OBJS) -o $@ $(LIBS)<br>
<br>
$(OBJDIR)/main/mkelfImage.o: main/mkelfImage.c include/mkelfImage.h $(DEPS)<br>
$(MKDIR) -p $(@D)<br>
- $(HOST_CC) $(HOST_CFLAGS) -c $< -o $@<br>
-+ $(CC) $(HOST_CFLAGS) -c $< -o $@<br>
++ $(CC) $(CFLAGS) -c $< -o $@<br>
<br>
$(OBJDIR)/man/man8/mkelfImage.8: main/mkelfImage.man<br>
$(MKDIR) -p $(@D)<br>
+--<br>
+2.8.0<br>
diff --git a/meta/recipes-devtools/mkelfimage/<a href="http://mkelfimage_git.bb" rel="noreferrer" target="_blank">mkelfimage_git.bb</a> b/meta/recipes-devtools/mkelfimage/<a href="http://mkelfimage_git.bb" rel="noreferrer" target="_blank">mkelfimage_git.bb</a><br>
index 92435cd..d7a4429 100644<br>
--- a/meta/recipes-devtools/mkelfimage/<a href="http://mkelfimage_git.bb" rel="noreferrer" target="_blank">mkelfimage_git.bb</a><br>
+++ b/meta/recipes-devtools/mkelfimage/<a href="http://mkelfimage_git.bb" rel="noreferrer" target="_blank">mkelfimage_git.bb</a><br>
@@ -13,8 +13,8 @@ <a href="http://review.coreboot.org/gitweb?p=coreboot.git;a=commit;h=34fc4ab80b507739e258" rel="noreferrer" target="_blank">http://review.coreboot.org/gitweb?p=coreboot.git;a=commit;h=34fc4ab80b507739e258</a><br>
DEPENDS += "zlib"<br>
<br>
SRC_URI = "git://<a href="http://review.coreboot.org/p/coreboot;protocol=http" rel="noreferrer" target="_blank">review.coreboot.org/p/coreboot;protocol=http</a> \<br>
- file://cross-compile.patch \<br>
- "<br>
+ file://cross-compile.patch \<br>
+ "<br>
SRC_URI_append_class-native = " \<br>
file://fix-makefile-to-find-libz.patch \<br>
"<br>
--<br>
2.8.0<br>
<br>
--<br>
_______________________________________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
</blockquote></div>