<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jun 1, 2016 at 5:35 AM, Richard Purdie <span dir="ltr"><<a href="mailto:richard.purdie@linuxfoundation.org" target="_blank">richard.purdie@linuxfoundation.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div id=":1mz" class="a3s aXjCH m1550bf7143fffdb2">diff --git a/meta/classes/base.<span class="il">bbclass</span> b/meta/classes/base.<span class="il">bbclass</span><br>
index 4be0a7e..1ba1222 100644<br>
--- a/meta/classes/base.<span class="il">bbclass</span><br>
+++ b/meta/classes/base.<span class="il">bbclass</span><br>
@@ -456,15 +456,15 @@ python () {<br>
# If we're building a target package we need to use fakeroot (pseudo)<br>
# in order to capture permissions, owners, groups and special files<br>
if not <span class="il">bb</span>.data.inherits_class('native', d) and not <span class="il">bb</span>.data.inherits_class('cross', d):<br>
- d.setVarFlag('do_unpack', 'umask', '022')<br>
- d.setVarFlag('do_configure', 'umask', '022')<br>
- d.setVarFlag('do_compile', 'umask', '022')<br>
+ d.setVarFlag('do_unpack', 'umask', '0o022')<br>
+ d.setVarFlag('do_configure', 'umask', '0o022')<br>
+ d.setVarFlag('do_compile', 'umask', '0o022')<br>
d.appendVarFlag('do_install', 'depends', ' virtual/fakeroot-native:do_populate_sysroot')<br>
d.setVarFlag('do_install', 'fakeroot', '1')<br>
- d.setVarFlag('do_install', 'umask', '022')<br>
+ d.setVarFlag('do_install', 'umask', '0o022')<br>
d.appendVarFlag('do_package', 'depends', ' virtual/fakeroot-native:do_populate_sysroot')<br>
d.setVarFlag('do_package', 'fakeroot', '1')<br>
- d.setVarFlag('do_package', 'umask', '022')<br>
+ d.setVarFlag('do_package', 'umask', '0o022')<br>
d.setVarFlag('do_package_setscene', 'fakeroot', '1')<br>
d.appendVarFlag('do_package_setscene', 'depends', ' virtual/fakeroot-native:do_populate_sysroot')<br>
d.setVarFlag('do_devshell', 'fakeroot', '1')</div></blockquote></div><br>Rather than modifying the string values in the metadata, shouldn't we retain compatibility by letting the umask *string* stored in the flag use the old format and if needed convert it when we convert the string to a number to pass to the appropriate os functions? Or was this just a sed gone wild, since these are string values, not python source octal syntax?<br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">Christopher Larson<br>clarson at kergoth dot com<br>Founder - BitBake, OpenEmbedded, OpenZaurus<br>Maintainer - Tslib<br>Senior Software Engineer, Mentor Graphics</div>
</div></div>