<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jun 7, 2016 at 2:06 PM, Paul Eggleton <span dir="ltr">&lt;<a href="mailto:paul.eggleton@linux.intel.com" target="_blank">paul.eggleton@linux.intel.com</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="">&gt; +    for pkg in packages:<br>
&gt; +        items.append((&quot;%s %s%s%s %s %s%s%s %s&quot; % (<br>
&gt; +            pkg,<br>
&gt; +            mappings[pkg][&#39;PKGE&#39;] + &quot;:&quot; if mappings[pkg][&#39;PKGE&#39;] else &quot;&quot;,<br>
&gt; +            mappings[pkg][&#39;PKGV&#39;],<br>
&gt; +            &quot;-&quot; + mappings[pkg][&#39;PKGR&#39;] if mappings[pkg][&#39;PKGR&#39;] else &quot;&quot;,<br>
&gt; +            mappings[pkg][&#39;PN&#39;],<br>
&gt; +            mappings[pkg][&#39;PE&#39;] + &quot;:&quot; if mappings[pkg][&#39;PE&#39;] else &quot;&quot;,<br>
&gt; +            mappings[pkg][&#39;PV&#39;],<br>
&gt; +            &quot;-&quot; + mappings[pkg][&#39;PR&#39;] if mappings[pkg][&#39;PR&#39;] else &quot;&quot;,<br>
&gt; +            mappings[pkg][&#39;PKGSIZE&#39;]<br>
&gt; +        )).strip()<br>
&gt; +        )<br>
<br>
</div></div>This seems like a bit of an ugly construction. If it were me writing it I<br>
would probably break it down using variables rather than trying to do it all<br>
on one line. That said it&#39;s not bad enough to block it, if nobody else feels<br>
strongly about it then you&#39;re in the clear.</blockquote></div><br>I&#39;d agree, that&#39;s not particularly readable, both due to the long single line and overuse of the inline if.<br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">Christopher Larson<br>clarson at kergoth dot com<br>Founder - BitBake, OpenEmbedded, OpenZaurus<br>Maintainer - Tslib<br>Senior Software Engineer, Mentor Graphics</div>
</div></div>