<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jun 16, 2016 at 7:27 AM, Jose Pardeiro <span dir="ltr"><<a href="mailto:jpardeiro@rapyuta-robotics.com" target="_blank">jpardeiro@rapyuta-robotics.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div id=":1ui" class="">Signed-off-by: Jose Pardeiro <<a href="mailto:jpardeiro@rapyuta-robotics.com">jpardeiro@rapyuta-robotics.com</a>></div></blockquote></div><br>I can't speak to the content, not knowing cmake very well, but this commit message violates general git commit message policy and yocto's specifically. <br><br clear="all"><div><a href="http://openembedded.org/wiki/Commit_Patch_Message_Guidelines">http://openembedded.org/wiki/Commit_Patch_Message_Guidelines</a><br></div><div><br></div><div>Thanks for the contribution, though, it's appreciated. Perhaps someone else can comment on the patch itself.</div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">Christopher Larson<br>clarson at kergoth dot com<br>Founder - BitBake, OpenEmbedded, OpenZaurus<br>Maintainer - Tslib<br>Senior Software Engineer, Mentor Graphics</div>
</div></div>