<html><head></head><body><div>Ping! This hasn't been merged, yet I haven't seen any further comments.</div><div> - Markus</div><div><br></div><div><br></div><div>On Wed, 2016-05-11 at 06:34 +0200, Petter Mabäcker wrote:</div><blockquote type="cite">
<pre>Hi Markus,
From my point of view it looks good, and all feedback from v2 of the patch seems to have been handled as well.
BR Petter<br><br></pre>
<pre>Petter Mabäcker
Technux <petter@technux.se>
www.technux.se</pre>
<p>2016-05-10 09:56 skrev Markus Lehtonen:</p>
<blockquote type="cite" style="padding-left:5px; border-left:#1010ff 2px solid; margin-left:5px; width:100%"><!-- html ignored --><!-- head ignored --><!-- meta ignored -->
<pre>Ping,
Any comments on this one?
Discussion on v2 of the patch:
<a href="http://lists.openembedded.org/pipermail/openembedded-core/2016-March/119295.html">http://lists.openembedded.org/pipermail/openembedded-core/2016-March/119295.html</a>
Cheers,
Markus
On 22/03/16 18:47, "Markus Lehtonen" <<a href="mailto:openembedded-core-bounces@lists.openembedded.org">openembedded-core-bounces@lists.openembedded.org</a> on behalf of <a href="mailto:markus.lehtonen@linux.intel.com">markus.lehtonen@linux.intel.com</a>> wrote:</pre>
<blockquote type="cite" style="padding-left:5px; border-left:#1010ff 2px solid; margin-left:5px; width:100%">Make sure that we have a pristine source tree after do_unpack. [YOCTO #9064] Signed-off-by: Markus Lehtonen <<a href="mailto:markus.lehtonen@linux.intel.com">markus.lehtonen@linux.intel.com</a>> --- meta/classes/base.bbclass | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass index e066dc9..2acb2b6 100644 --- a/meta/classes/base.bbclass +++ b/meta/classes/base.bbclass @@ -133,23 +133,15 @@ python base_do_fetch() { addtask unpack after do_fetch do_unpack[dirs] = "${WORKDIR}" +do_unpack[cleandirs] = "<a href="mailto:${@d.getVar">${@d.getVar</a>('S', True) if d.getVar('S', True) != d.getVar('WORKDIR', True) else os.path.join(d.getVar('S', True), 'patches')}" python base_do_unpack() { src_uri = (d.getVar('SRC_URI', True) or "").split() if len(src_uri) == 0: return - rootdir = d.getVar('WORKDIR', True) - - # Ensure that we cleanup ${S}/patches - # TODO: Investigate if we can remove - # the entire ${S} in this case. - s_dir = d.getVar('S', True) - p_dir = os.path.join(s_dir, 'patches') - bb.utils.remove(p_dir, True) - try: fetcher = bb.fetch2.Fetch(src_uri, d) - fetcher.unpack(rootdir) + fetcher.unpack(d.getVar('WORKDIR', True)) except bb.fetch2.BBFetchException as e: raise bb.build.FuncFailed(e) } -- 2.6.2 <span class="sig">-- _______________________________________________ Openembedded-core mailing list <a href="mailto:Openembedded-core@lists.openembedded.org">Openembedded-core@lists.openembedded.org</a> <a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a> </span></blockquote>
</blockquote>
<pre>--
_______________________________________________
Openembedded-core mailing list
<a href="mailto:Openembedded-core@lists.openembedded.org">Openembedded-core@lists.openembedded.org</a>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a>
</pre></blockquote><div><br></div></body></html>