<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Aug 4, 2016 at 3:48 AM, Jacob Kroon <span dir="ltr"><<a href="mailto:jacob.kroon@gmail.com" target="_blank">jacob.kroon@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 08/04/2016 03:41 AM, Bruce Ashfield wrote:<br>
</span><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
On Wed, Aug 3, 2016 at 5:33 AM, Jacob Kroon <<a href="mailto:jacob.kroon@gmail.com" target="_blank">jacob.kroon@gmail.com</a><br></span>
<mailto:<a href="mailto:jacob.kroon@gmail.com" target="_blank">jacob.kroon@gmail.com</a>>> wrote:<br>
</blockquote>
[...]<span class=""><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Ignore this patch, I'm suspecting that .kernel-meta/ directory<br>
shouldn't exist in ${STAGING_KERNEL_DIR} to begin with ?<br>
<br>
<br>
It doesn't hurt anything by being there, but you can either intercept it<br>
at the<br>
time we stage the common kernel parts, or when you package devsrc .. either<br>
will work.<br>
</blockquote>
<br></span>
Since commit 3b49416fc7a7ee9bfe722f2e6089aa18df41dc58, linux-yocto.inc<br>
does:<br>
<br>
do_install_append(){<br>
if [ -n "${KMETA}" ]; then<br>
rm -rf ${STAGING_KERNEL_DIR}/${KMETA}<br>
fi<br>
}<br>
<br>
But I think this accidentally got broken by a later commit<br>
3b2b4eef0fd06099342fcc2dfa35ecf37840c090, which changed the directory<br>
name by conditionally prepending a ".":<br>
<br>
kmeta = d.getVar( "KMETA", True ) or "meta"<br>
if not os.path.exists(kmeta):<br>
kmeta = "." + kmeta<br>
<br>
So it seems to me that the right thing to do here would be to fix and<br>
move the do_install_append() to kernel-yocto.bbclass. Bruce, what do<br>
you think ?<br></blockquote><div><br></div><div>Yep, that rm -rf could be both ${KMETA} and .${KMETA}. If either exist, they should be removed. Whether it is in the .inc or the bbclass isn't significant. I'd leave it where it is as smallest footprint action.<br><br></div><div>Bruce<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Regards Jacob<br>
</blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">"Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"</div>
</div></div>