<div dir="ltr">Thanks Max!<div><br></div><div>I like your approach a lot; and yes, the same fix works in our /etc/profile.</div><div><br></div><div>-Brian</div><div>an Intel employee</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Aug 5, 2016 at 1:58 AM, Max Krummenacher <span dir="ltr"><<a href="mailto:max.oss.09@gmail.com" target="_blank">max.oss.09@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Brian<br>
<div><div class="h5"><br>
Am Donnerstag, den 04.08.2016, 19:49 -0700 schrieb Khem Raj:<br>
><br>
> On 8/4/16 2:20 PM, Brian Avery wrote:<br>
> > The core issue:<br>
> > The busybox resize command breaks the eclipse ssh debug stream.<br>
> > This is<br>
> > because the resize command for busybox sends a set of cursor<br>
> > control<br>
> > escape sequences to stderr. The resize cfg was added to Krogoth and<br>
> > is<br>
> > still in master. The point of resize is to set the environment and<br>
> > terminal settings to the current xterm window size.<br>
> ><br>
> > Additional complexity:<br>
> > eclipse-debug is an IMAGE_FEATURE. If it is turned on by a user in<br>
> > local.conf via EXTRA_IMAGE_FEATURES then I can conditionally turn<br>
> > off<br>
> > busybox/resize in the cfg file. Unfortunately, if a user makes a<br>
> > new<br>
> > image with IMAGE_FEATURES += " eclipse-debug " in it, I do not see<br>
> > this<br>
> > from the scope of the busybox##.bb recipe.<br>
> ><br>
> > So, there are a couple of ways to solve this and I'm not sure which<br>
> > is<br>
> > the best one.<br>
> ><br>
> > 1) conditionally turn off the resize.cfg if eclipse-debug is in<br>
> > extra-image-features. Also, make a rm_resize.bbclass to rm the<br>
> > usr/bin/resize from the rootfs in a do_rootfs[postfuncs] which can<br>
> > be<br>
> > inherited by the various sdk images we build.<br>
> ><br>
> > This is problematic since if a user makes a new image recipe of<br>
> > their<br>
> > own and includes eclipse-debug but doesn't inherit the<br>
> > rm_resize.bbclass<br>
> > eclipse debug will fail.<br>
> ><br>
> > 2) elevate eclipse-debug to a distro feature which would make it<br>
> > visible<br>
> > to the busybox###.bb recipe. Unfortunately, it is really an image<br>
> > specific set of packages to be included so elevating it doesn't<br>
> > seem<br>
> > reasonable.<br>
> ><br>
> > 3) use the update-alternatives method (busybox is currently doing<br>
> > this<br>
> > for syslog) to make a separate busybox-resize package and make an<br>
> > eclipse friendly resize package that is empty and add the eclipse<br>
> > one to<br>
> > the eclipse-debug packagegroup.<br>
> ><br>
> > 4) Just turn off resize or patch it so it doesn't try to control<br>
> > the<br>
> > cursor via escape sequences sent to stderr but still sets up the<br>
> > environment. It's worth noting that the ubuntu resize doesn't<br>
> > send<br>
> > escape sequences to any of the streams.<br>
><br>
> this seems to be best option.<br>
<br>
</div></div>We fixed this by only executing resize if logging in from a serial<br>
console:<br>
<br>
<a href="http://git.toradex.com/cgit/meta-toradex.git/commit/?h=V2.6-next&id=9d1
32ea3cf75562ef5610dd6ff1c89d0cffa334d" rel="noreferrer" target="_blank">http://git.toradex.com/cgit/<wbr>meta-toradex.git/commit/?h=V2.<wbr>6-next&id=9d1<br>
32ea3cf75562ef5610dd6ff1c89d0c<wbr>ffa334d</a><br>
<br>
I guess one could apply the same fix to here<br>
<a href="http://cgit.openembedded.org/openembedded-core/tree/meta/recipes-core/b
ase-files/base-files/profile?h=krogoth" rel="noreferrer" target="_blank">http://cgit.openembedded.org/<wbr>openembedded-core/tree/meta/<wbr>recipes-core/b<br>
ase-files/base-files/profile?<wbr>h=krogoth</a><br>
<br>
Regards<br>
<span class="HOEnZb"><font color="#888888">Max<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
> ><br>
> > 5) Something else?<br>
> ><br>
> > Thanks,<br>
> > Brian<br>
> > an Intel employee<br>
> ><br>
> ><br>
> ><br>
> ><br>
<br>
</div></div></blockquote></div><br></div>