<div dir="ltr">Hi,<br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Aug 19, 2016 at 5:45 PM, Richard Purdie <span dir="ltr"><<a href="mailto:richard.purdie@linuxfoundation.org" target="_blank">richard.purdie@linuxfoundation.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="">On Fri, 2016-08-19 at 17:35 +0300, Ed Bartosh wrote:<br>
> Recent renaming of COMPRESSIONTYPES variable can break recipes that<br>
> still use it. Including value of COMPRESSIONTYPES variable into<br>
> CONVERSIONTYPES should prevent this.<br>
><br>
> Signed-off-by: Ed Bartosh <<a href="mailto:ed.bartosh@linux.intel.com">ed.bartosh@linux.intel.com</a>><br>
> ---<br>
> meta/classes/image_types.<wbr>bbclass | 8 +++++++-<br>
> 1 file changed, 7 insertions(+), 1 deletion(-)<br>
<br>
</span>Does this actually work? Won't COMPRESSION_CMD be unset in these cases<br>
so it would just trigger further failures?<br>
<br>
Perhaps we should just error and tell the user if COMPRESSION_TYPES is<br>
set (in sanity.bbclass?).<br></blockquote><div><br></div><div>These lines were simply missing from 9d68c024790850cab72ead1e3372a5fcec4ef7b0</div><div>(the commit message talks about these lines).</div><div><br></div><div>In Ostro we add a few custom conversions via COMPRESSIONTYPES_append and without</div><div>this patch those types are not recognized and we hit:</div><div><br></div><div>"No IMAGE_CMD defined for IMAGE_FSTYPES entry 'dsk.ova' - possibly invalid type name or missing support class"<br></div><div><br></div><div>(ova is one of our COMPRESSIONTYPES).</div><div><br></div><div>-- Mikko</div></div></div></div>