<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <p><br>
    </p>
    <br>
    <div class="moz-cite-prefix">On 23/08/2016 15:41, Bruce Ashfield
      wrote:<br>
    </div>
    <blockquote
cite="mid:CADkTA4OTbF_nTfz7Afi33mDX2yBe7SVC+DXA7NAH9tme=RZ7aA@mail.gmail.com"
      type="cite">
      <div dir="ltr"><br>
        <div class="gmail_extra"><br>
          <div class="gmail_quote">On Tue, Aug 23, 2016 at 9:36 AM,
            Bruce Ashfield <span dir="ltr">&lt;<a
                moz-do-not-send="true"
                href="mailto:bruce.ashfield@gmail.com" target="_blank">bruce.ashfield@gmail.com</a>&gt;</span>
            wrote:<br>
            <blockquote class="gmail_quote" style="margin:0 0 0
              .8ex;border-left:1px #ccc solid;padding-left:1ex">
              <div dir="ltr">
                <div>
                  <div class="gmail_extra">
                    <div class="gmail_quote"><span class="">On Tue, Aug
                        23, 2016 at 3:25 AM, Jérémy Rosen <span
                          dir="ltr">&lt;<a moz-do-not-send="true"
                            href="mailto:jeremy.rosen@smile.fr"
                            target="_blank">jeremy.rosen@smile.fr</a>&gt;</span>
                        wrote:<br>
                        <blockquote class="gmail_quote" style="margin:0
                          0 0 .8ex;border-left:1px #ccc
                          solid;padding-left:1ex">The KConfig
                          infrastructure hardwires the compiler name to
                          gcc, which breaks<br>
                          the BUILD_CC feature. This is needed even when
                          cross compiling because<br>
                          make *config rely on the kconfig
                          infrastructure<br>
                        </blockquote>
                        <div><br>
                        </div>
                      </span>
                      <div>Can you elaborate ? I'm not aware of any
                        issues with either the host builds or<br>
                      </div>
                      <div>target builds with the kernel.<br>
                      </div>
                    </div>
                  </div>
                </div>
              </div>
            </blockquote>
            <div><br>
            </div>
            <div>Aha. I found the 0/N for the series.<br>
              <br>
            </div>
            <div>And my answer is still the same. These belong upstream,
              and since the kernel is fairly<br>
            </div>
            <div>picky about the compiler and compiler versions, I don't
              see a pressing need to carry<br>
            </div>
            <div>something like this until it makes it into the mainline
              kernel.<br>
              <br>
            </div>
            <div>My answer to 'can't assume the name of gcc', is to make
              sure that your environment<br>
            </div>
            <div>and path is fully understood, and make your compiler
              available as 'gcc', versus trying<br>
            </div>
            <div>to patch multiple recipes.<br>
            </div>
          </div>
        </div>
      </div>
    </blockquote>
    <br>
    Ok, my 0/N maybe was not as clear as I hoped. I don't want to
    compile without a gcc binary. I want to make sure that when I set
    BUILD_* to a specific version of gcc (gcc-5 in my case) only that
    version of the compiler can be used.<br>
    <br>
    As pointed, jethro can only be compiled on a machine where the
    default compiler is gcc-5. Having gcc-5 installed is not enough, it
    needs to be default. The BUILD_* feature was meant to prevent that,
    i'm just fixing it<br>
    <br>
    As I have stated elsewhere, I am upstreaming the patches in
    parlallel (only the glibc patch is left at this point, since I found
    a way to drop the kconfig ones) hopefully I will be able to add the
    "submitted upstream" tag on V2.<br>
    <br>
    In the meantime, I mainly wanted comments on the approch and I was
    wondering how to makes sure some sort of autmated QA test could
    detect that sort of problems.<br>
    <br>
    Hope this helps<br>
    Jeremy<br>
    <br>
    <blockquote
cite="mid:CADkTA4OTbF_nTfz7Afi33mDX2yBe7SVC+DXA7NAH9tme=RZ7aA@mail.gmail.com"
      type="cite">
      <div dir="ltr">
        <div class="gmail_extra">
          <div class="gmail_quote">
            <div><br>
            </div>
            <div>Cheers,<br>
              <br>
            </div>
            <div>Bruce<br>
            </div>
            <div> </div>
            <blockquote class="gmail_quote" style="margin:0 0 0
              .8ex;border-left:1px #ccc solid;padding-left:1ex">
              <div dir="ltr">
                <div>
                  <div class="gmail_extra">
                    <div class="gmail_quote">
                      <div><br>
                      </div>
                      <div>If there's an issue, we need to fix it
                        upstream .. not here.<br>
                      </div>
                      <span class="">
                        <div> </div>
                        <blockquote class="gmail_quote" style="margin:0
                          0 0 .8ex;border-left:1px #ccc
                          solid;padding-left:1ex">
                          ---<br>
                           meta/recipes-kernel/linux/lin<wbr>ux-yocto.inc 
                                                                       
                                       |  4 ++++<br>
                           meta/recipes-kernel/linux/lin<wbr>ux-yocto/0001-Allow-overriding<wbr>-host-compiler-name-from-<wbr>environment.patch
                          | 32 ++++++++++++++++++++++++++++++<wbr>++<br>
                           2 files changed, 36 insertions(+), 0
                          deletions(-)<br>
                           create mode 100644
                          meta/recipes-kernel/linux/linu<wbr>x-yocto/0001-Allow-overriding-<wbr>host-compiler-name-from-<wbr>environment.patch<br>
                          <br>
                          diff --git a/meta/recipes-kernel/linux/li<wbr>nux-yocto.inc
                          b/meta/recipes-kernel/linux/li<wbr>nux-yocto.inc<br>
                          index 98a48ec..63c1531 100644<br>
                          --- a/meta/recipes-kernel/linux/li<wbr>nux-yocto.inc<br>
                          +++ b/meta/recipes-kernel/linux/li<wbr>nux-yocto.inc<br>
                          @@ -58,3 +58,7 @@ do_install_append(){<br>
                           addtask kernel_link_images after do_compile
                          before do_install<br>
                           addtask validate_branches before do_patch
                          after do_kernel_checkout<br>
                           addtask kernel_configcheck after do_configure
                          before do_compile<br>
                          +<br>
                          +SRC_URI_append = "
                          <a class="moz-txt-link-freetext" href="file://0001-Allow-overriding-h">file://0001-Allow-overriding-h</a><wbr>ost-compiler-name-from-environ<wbr>ment.patch"<br>
                        </blockquote>
                        <div><br>
                        </div>
                      </span>
                      <div>We don't carry patches to linux-yocto like
                        this, they are sent to the linux-yocto mailing
                        list, and<br>
                      </div>
                      <div>integrated into the tree itself.<br>
                        <br>
                      </div>
                      <div>Bruce<br>
                      </div>
                      <div>
                        <div class="h5">
                          <div> </div>
                          <blockquote class="gmail_quote"
                            style="margin:0 0 0 .8ex;border-left:1px
                            #ccc solid;padding-left:1ex">
                            +export HOSTCC = "${BUILD_CC}"<br>
                            +export HOSTCXX = "${BUILD_CXX}"<br>
                            diff --git a/meta/recipes-kernel/linux/li<wbr>nux-yocto/0001-Allow-overridin<wbr>g-host-compiler-name-from-<wbr>environment.patch
                            b/meta/recipes-kernel/linux/li<wbr>nux-</blockquote>
                          <blockquote class="gmail_quote"
                            style="margin:0 0 0 .8ex;border-left:1px
                            #ccc solid;padding-left:1ex">yocto/0001-Allow-overriding-<wbr>host-compiler-name-from-<wbr>environment.patch<br>
                            new file mode 100644<br>
                            index 0000000..6fcfbc8<br>
                            --- /dev/null<br>
                            +++ b/meta/recipes-kernel/linux/li<wbr>nux-yocto/0001-Allow-overridin<wbr>g-host-compiler-name-from-<wbr>environment.patch<br>
                            @@ -0,0 +1,32 @@<br>
                            +From 0ce4c4f29b5d456a7707e870c7affe<wbr>524f7c8807
                            Mon Sep 17 00:00:00 2001<br>
                            +From: =?UTF-8?q?J=C3=A9r=C3=A9my=20R<wbr>osen?=
                            &lt;<a moz-do-not-send="true"
                              href="mailto:jeremy.rosen@smile.fr"
                              target="_blank">jeremy.rosen@smile.fr</a>&gt;<br>
                            +Date: Tue, 16 Aug 2016 22:39:29 +0200<br>
                            +Subject: [PATCH] Allow overriding
                            host-compiler name from environment<br>
                            + variables<br>
                            +<br>
                            +---<br>
                            + Makefile | 8 ++++----<br>
                            + 1 file changed, 4 insertions(+), 4
                            deletions(-)<br>
                            +<br>
                            +diff --git a/Makefile b/Makefile<br>
                            +index 70dea02..1f0d2d2 100644<br>
                            +--- a/Makefile<br>
                            ++++ b/Makefile<br>
                            +@@ -295,10 +295,10 @@ CONFIG_SHELL :=
                            $(shell if [ -x "$$BASH" ]; then echo
                            $$BASH; \<br>
                            +         else if [ -x /bin/bash ]; then
                            echo /bin/bash; \<br>
                            +         else echo sh; fi ; fi)<br>
                            +<br>
                            +-HOSTCC       = gcc<br>
                            +-HOSTCXX      = g++<br>
                            +-HOSTCFLAGS   = -Wall -Wmissing-prototypes
                            -Wstrict-prototypes -O2 -fomit-frame-pointer
                            -std=gnu89<br>
                            +-HOSTCXXFLAGS = -O2<br>
                            ++HOSTCC       ?= gcc<br>
                            ++HOSTCXX      ?= g++<br>
                            ++HOSTCFLAGS   ?= -Wall -Wmissing-prototypes
                            -Wstrict-prototypes -O2 -fomit-frame-pointer
                            -std=gnu89<br>
                            ++HOSTCXXFLAGS ?= -O2<br>
                            +<br>
                            + ifeq ($(shell $(HOSTCC) -v 2&gt;&amp;1 |
                            grep -c "clang version"), 1)<br>
                            + HOSTCFLAGS  += -Wno-unused-value
                            -Wno-unused-parameter \<br>
                            +--<br>
                            +2.8.1<br>
                            +<br>
                            <span><font color="#888888">--<br>
                                git-series 0.8.9<br>
                                --<br>
                                ______________________________<wbr>_________________<br>
                                Openembedded-core mailing list<br>
                                <a moz-do-not-send="true"
                                  href="mailto:Openembedded-core@lists.openembedded.org"
                                  target="_blank">Openembedded-core@lists.openem<wbr>bedded.org</a><br>
                                <a moz-do-not-send="true"
                                  href="http://lists.openembedded.org/mailman/listinfo/openembedded-core"
                                  rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/openembedded-<wbr>core</a><br>
                              </font></span></blockquote>
                        </div>
                      </div>
                    </div>
                    <span class="HOEnZb"><font color="#888888"><br>
                        <br clear="all">
                        <br>
                        -- <br>
                        <div data-smartmail="gmail_signature">"Thou
                          shalt not follow the NULL pointer, for chaos
                          and madness await thee at its end"</div>
                      </font></span></div>
                </div>
              </div>
            </blockquote>
          </div>
          <br>
          <br clear="all">
          <br>
          -- <br>
          <div class="gmail_signature" data-smartmail="gmail_signature">"Thou
            shalt not follow the NULL pointer, for chaos and madness
            await thee at its end"</div>
        </div>
      </div>
    </blockquote>
    <br>
  </body>
</html>