<div dir="ltr">changing it to DEPEND would only make it worse an more useless</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Aug 22, 2016 at 7:01 PM, Slater, Joseph <span dir="ltr"><<a href="mailto:joe.slater@windriver.com" target="_blank">joe.slater@windriver.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">At the cost of a little build time, I guess we could lose the inherit allarch.<br>
As a practical matter, we could get rid of the RDEPEND (or make it a DEPEND?),<br>
but that seems wrong, somehow.<br>
<br>
Joe<br>
<div class="HOEnZb"><div class="h5"><br>
> -----Original Message-----<br>
> From: Martin Jansa [mailto:<a href="mailto:martin.jansa@gmail.com">martin.jansa@gmail.com</a><wbr>]<br>
> Sent: Monday, August 22, 2016 7:21 AM<br>
> To: <a href="mailto:openembedded-core@lists.openembedded.org">openembedded-core@lists.<wbr>openembedded.org</a>; Slater, Joseph<br>
> Cc: <a href="mailto:openembedded-commits@lists.openembedded.org">openembedded-commits@lists.<wbr>openembedded.org</a><br>
> Subject: Re: [oe-commits] [openembedded-core] 01/02: systemd-compat-units: pkg_postinst()<br>
> does not work<br>
><br>
> On Thu, Aug 18, 2016 at 03:52:33PM +0000, <a href="mailto:git@git.openembedded.org">git@git.openembedded.org</a> wrote:<br>
> > rpurdie pushed a commit to branch master<br>
> > in repository openembedded-core.<br>
> ><br>
> > commit 8183309080aee45746daaff46b0506<wbr>b09b5bd269<br>
> > Author: Joe Slater <<a href="mailto:jslater@windriver.com">jslater@windriver.com</a>><br>
> > AuthorDate: Mon Aug 15 16:04:53 2016 -0700<br>
> ><br>
> > systemd-compat-units: pkg_postinst() does not work<br>
> ><br>
> > The test for various files is wrong and will always be<br>
> > true, even if init.d does not exist.<br>
> ><br>
> > Exit if init.d does not exist, and correctly test for<br>
> > file existence otherwise.<br>
> ><br>
> > Signed-off-by: Joe Slater <<a href="mailto:jslater@windriver.com">jslater@windriver.com</a>><br>
> > Signed-off-by: Ross Burton <<a href="mailto:ross.burton@intel.com">ross.burton@intel.com</a>><br>
> > ---<br>
> > meta/recipes-core/systemd/<a href="http://systemd-compat-units.bb" rel="noreferrer" target="_blank">syst<wbr>emd-compat-units.bb</a> | 17 ++++++++++-------<br>
> > 1 file changed, 10 insertions(+), 7 deletions(-)<br>
> ><br>
> > diff --git a/meta/recipes-core/systemd/<a href="http://systemd-compat-units.bb" rel="noreferrer" target="_blank">sy<wbr>stemd-compat-units.bb</a> b/meta/recipes-<br>
> core/systemd/<a href="http://systemd-compat-units.bb" rel="noreferrer" target="_blank">systemd-compat-<wbr>units.bb</a><br>
> > index 0b8ff09..90811da 100644<br>
> > --- a/meta/recipes-core/systemd/<a href="http://systemd-compat-units.bb" rel="noreferrer" target="_blank">sy<wbr>stemd-compat-units.bb</a><br>
> > +++ b/meta/recipes-core/systemd/<a href="http://systemd-compat-units.bb" rel="noreferrer" target="_blank">sy<wbr>stemd-compat-units.bb</a><br>
> > @@ -23,21 +23,24 @@ SYSTEMD_DISABLED_SYSV_SERVICES = " \<br>
> > "<br>
> ><br>
> > pkg_postinst_${PN} () {<br>
> > - cd $D${sysconfdir}/init.d<br>
> ><br>
> > - echo "Disabling the following sysv scripts: "<br>
> > + cd $D${sysconfdir}/init.d || exit 0<br>
> ><br>
> > - OPTS=""<br>
> > + echo "Disabling the following sysv scripts: "<br>
> ><br>
> > if [ -n "$D" ]; then<br>
> > OPTS="--root=$D"<br>
> > + else<br>
> > + OPTS=""<br>
> > fi<br>
> ><br>
> > for i in ${SYSTEMD_DISABLED_SYSV_<wbr>SERVICES} ; do<br>
> > - if [ \( -e $i -o $i.sh \) -a ! \( -e $D${sysconfdir}/systemd/<wbr>system/$i.service -<br>
> o -e $D${systemd_unitdir}/system/$<wbr>i.service \) ] ; then<br>
> > - echo -n "$i: " ; systemctl ${OPTS} mask $i.service<br>
> > + if [ -e $i -o -e $i.sh ] && ! [ -e $D${sysconfdir}/systemd/<wbr>system/$i.service<br>
> -o -e $D${systemd_unitdir}/system/$<wbr>i.service ] ; then<br>
> > + echo -n "$i: "<br>
> > + systemctl $OPTS mask $i.service<br>
> > fi<br>
> > - done ; echo<br>
> > + done<br>
> > + echo<br>
> > }<br>
> ><br>
> > -RDPEPENDS_${PN} = "systemd"<br>
> > +RDEPENDS_${PN} = "systemd"<br>
><br>
> This is good typo fix, but also causes allarch systemd-compat-units to<br>
> RDEPENDS on TUNE_PKGARCH systemd as reported in:<br>
> <a href="http://lists.openembedded.org/pipermail/openembedded-core/2016-August/125483.html" rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>pipermail/openembedded-core/<wbr>2016-August/125483.html</a><br>
><br>
> So either please exclude it in layer.conf for drop this runtime<br>
> dependency completely.<br>
><br>
> --<br>
> Martin 'JaMa' Jansa jabber: <a href="mailto:Martin.Jansa@gmail.com">Martin.Jansa@gmail.com</a><br>
</div></div></blockquote></div><br></div>