<div dir="ltr"><div><div><div>Hi,<br><br></div>Let me know if this patch is ok. Else I can help make this patch better.<br><br></div>Thanks,<br></div>Sujith H<br><div><div><div><div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Sep 21, 2016 at 3:12 PM, Sujith H <span dir="ltr"><<a href="mailto:sujith.h@gmail.com" target="_blank">sujith.h@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Fahad Usman <<a href="mailto:fahad_usman@mentor.com">fahad_usman@mentor.com</a>><br>
<br>
Tried by adding CFLAGS_append = " -fpic " to<br>
the recipe. But that couldn't help resolve the<br>
warning message:<br>
<br>
x264/r2491+gitAUTOINC+<wbr>c8a773ebfc-r0/packages-split/<wbr>x264/usr/lib/libx264.so.144' has relocations in .text [textrel]<br>
<br>
It was found that this warning is emitted because of the<br>
assembly files in the source code. And it is not easy to<br>
get rid of TEXTREL's which are coming from the assembly<br>
source files.<br>
<br>
Adding textrel to INSANE_SKIP resolves this issue.<br>
This issue was observed in cyclone5 and imx6qsabresd BSP's.<br>
So generalizing the patch.<br>
<br>
Signed-off-by: Fahad Usman <<a href="mailto:fahad_usman@mentor.com">fahad_usman@mentor.com</a>><br>
Signed-off-by: Sujith Haridasan <<a href="mailto:Sujith_Haridasan@mentor.com">Sujith_Haridasan@mentor.com</a>><br>
---<br>
meta/recipes-multimedia/x264/<a href="http://x264_git.bb" rel="noreferrer" target="_blank">x<wbr>264_git.bb</a> | 4 ++--<br>
1 file changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/meta/recipes-multimedia/<wbr>x264/<a href="http://x264_git.bb" rel="noreferrer" target="_blank">x264_git.bb</a> b/meta/recipes-multimedia/<wbr>x264/<a href="http://x264_git.bb" rel="noreferrer" target="_blank">x264_git.bb</a><br>
index fa44f9c..393310f 100644<br>
--- a/meta/recipes-multimedia/<wbr>x264/<a href="http://x264_git.bb" rel="noreferrer" target="_blank">x264_git.bb</a><br>
+++ b/meta/recipes-multimedia/<wbr>x264/<a href="http://x264_git.bb" rel="noreferrer" target="_blank">x264_git.bb</a><br>
@@ -48,6 +48,6 @@ do_install() {<br>
oe_runmake install DESTDIR=${D}<br>
}<br>
<br>
-# PIC can't be enabled for 32-bit x86<br>
-INSANE_SKIP_${PN}_append_x86 = " textrel"<br>
+# PIC can't be enabled for few BSP's<br>
+INSANE_SKIP_${PN}_append = " textrel"<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
1.9.1<br>
<br>
</font></span></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>സുജിത് ഹരിദാസന്<br>Bangalore<br><Project>Contributor to KDE project<br></div><div><Project>Contributor to Yocto project<br></div><div><a href="http://fci.wikia.com/wiki/Anti-DRM-Campaign" target="_blank">http://fci.wikia.com/wiki/Anti-DRM-Campaign</a><br><Blog> <a href="http://sujithh.info" target="_blank">http://sujithh.info</a><br></div><div>C-x C-c<br></div></div></div></div></div>
</div></div></div></div></div></div></div></div>