<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Oct 3, 2016 at 3:55 PM, Khem Raj <span dir="ltr"><<a href="mailto:raj.khem@gmail.com" target="_blank">raj.khem@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr">What Repercussion does this have wrt APIs headers for future. Provided this is a local patch. I think removing header includes like this can cause issues.</p></blockquote><div><br></div><div><br></div><div>It's something we could drop in the future, but these are mods that have been done since -rc4, and could very well be undone if they start breaking things like this.</div><div><br></div><div>The alternative is to try and fix the userspace applications, but I currently don't see a fast way to do that (and I'm now officially on vacation).</div><div><br></div><div>Cheers,</div><div><br></div><div>Bruce</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr"> </p><div class="HOEnZb"><div class="h5">
<div class="gmail_extra"><br><div class="gmail_quote">On Oct 3, 2016 9:55 AM, "Bruce Ashfield" <<a href="mailto:bruce.ashfield@windriver.com" target="_blank">bruce.ashfield@windriver.com</a>> wrote:<br type="attribution"><blockquote class="m_-7060553277164903007quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">commit 1fe8e0f074c [include/uapi/linux/if_tunnel.<wbr>h: include linux/if.h, linux/ip.h and linux/in6.h]<br>
breaks the builds of net-tools.<br>
<br>
We remove the new includes until such a time that userspace can adapt to the<br>
new kernel headers.<br>
<br>
Signed-off-by: Bruce Ashfield <<a href="mailto:bruce.ashfield@windriver.com" target="_blank">bruce.ashfield@windriver.com</a>><br>
---<br>
...1-if_tunnel-remove-<wbr>include-of-if-ip-in6.h.patch | 33 ++++++++++++++++++++++<br>
.../linux-libc-headers/<a href="http://linux-libc-headers_4.8.bb" rel="noreferrer" target="_blank">linux-<wbr>libc-headers_4.8.bb</a> | 1 +<br>
2 files changed, 34 insertions(+)<br>
create mode 100644 meta/recipes-kernel/linux-libc<wbr>-headers/linux-libc-headers/<wbr>0001-if_tunnel-remove-include-<wbr>of-if-ip-in6.h.patch<br>
<br>
diff --git a/meta/recipes-kernel/linux-li<wbr>bc-headers/linux-libc-headers/<wbr>0001-if_tunnel-remove-include-<wbr>of-if-ip-in6.h.patch b/meta/recipes-kernel/linux-li<wbr>bc-headers/linux-libc-headers/<wbr>0001-if_tunnel-remove-include-<wbr>of-if-ip-in6.h.patch<br>
new file mode 100644<br>
index 000000000000..f2011880dccb<br>
--- /dev/null<br>
+++ b/meta/recipes-kernel/linux-li<wbr>bc-headers/linux-libc-headers/<wbr>0001-if_tunnel-remove-include-<wbr>of-if-ip-in6.h.patch<br>
@@ -0,0 +1,33 @@<br>
+From 017ae5929312685c4c044765445bfd<wbr>4d2a4abb5c Mon Sep 17 00:00:00 2001<br>
+From: Bruce Ashfield <<a href="mailto:bruce.ashfield@windriver.com" target="_blank">bruce.ashfield@windriver.com</a>><br>
+Date: Mon, 3 Oct 2016 12:27:57 -0400<br>
+Subject: [PATCH] if_tunnel: remove include of if/ip/in6.h<br>
+<br>
+commit 1fe8e0f074c [include/uapi/linux/if_tunnel.<wbr>h: include linux/if.h, linux/ip.h and linux/in6.h]<br>
+breaks the builds of net-tools.<br>
+<br>
+We remove the new includes until such a time that userspace can adapt to the<br>
+new kernel headers.<br>
+<br>
+Signed-off-by: Bruce Ashfield <<a href="mailto:bruce.ashfield@windriver.com" target="_blank">bruce.ashfield@windriver.com</a>><br>
+---<br>
+ include/uapi/linux/if_tunnel.h | 3 ---<br>
+ 1 file changed, 3 deletions(-)<br>
+<br>
+diff --git a/include/uapi/linux/if_tunnel<wbr>.h b/include/uapi/linux/if_tunnel<wbr>.h<br>
+index 777b6cd..1046f55 100644<br>
+--- a/include/uapi/linux/if_tunnel<wbr>.h<br>
++++ b/include/uapi/linux/if_tunnel<wbr>.h<br>
+@@ -2,9 +2,6 @@<br>
+ #define _UAPI_IF_TUNNEL_H_<br>
+<br>
+ #include <linux/types.h><br>
+-#include <linux/if.h><br>
+-#include <linux/ip.h><br>
+-#include <linux/in6.h><br>
+ #include <asm/byteorder.h><br>
+<br>
+<br>
+--<br>
+2.7.4<br>
+<br>
diff --git a/meta/recipes-kernel/linux-li<wbr>bc-headers/<a href="http://linux-libc-headers_4.8.bb" rel="noreferrer" target="_blank">linux-libc-headers_<wbr>4.8.bb</a> b/meta/recipes-kernel/linux-li<wbr>bc-headers/<a href="http://linux-libc-headers_4.8.bb" rel="noreferrer" target="_blank">linux-libc-headers_<wbr>4.8.bb</a><br>
index 778f0b6e6443..ee2d8293450e 100644<br>
--- a/meta/recipes-kernel/linux-li<wbr>bc-headers/<a href="http://linux-libc-headers_4.8.bb" rel="noreferrer" target="_blank">linux-libc-headers_<wbr>4.8.bb</a><br>
+++ b/meta/recipes-kernel/linux-li<wbr>bc-headers/<a href="http://linux-libc-headers_4.8.bb" rel="noreferrer" target="_blank">linux-libc-headers_<wbr>4.8.bb</a><br>
@@ -10,6 +10,7 @@ SRC_URI_append_libc-musl = "\<br>
<br>
SRC_URI_append = "\<br>
file://0001-ppp-fix-in-if.h-i<wbr>ncludes.patch \<br>
+ file://0001-if_tunnel-remove-i<wbr>nclude-of-if-ip-in6.h.patch \<br>
"<br>
<br>
SRC_URI[md5sum] = "c1af0afbd3df35c1ccdc7a5118cd2<wbr>d07"<br>
<font color="#888888">--<br>
2.5.0<br>
<br>
--<br>
______________________________<wbr>_________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openem<wbr>bedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/openembedded-<wbr>core</a><br>
</font></blockquote></div><br></div>
</div></div><br>--<br>
______________________________<wbr>_________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org">Openembedded-core@lists.<wbr>openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/openembedded-<wbr>core</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">"Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"</div>
</div></div>