<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Oct 11, 2016 at 5:11 AM, Jagadeesh Krishnanjanappa <span dir="ltr"><<a href="mailto:jkrishnanjanappa@mvista.com" target="_blank">jkrishnanjanappa@mvista.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div>Thanks for reviewing the patch.<br><div class="gmail_extra"><br><div class="gmail_quote"><span class="gmail-"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span class="gmail-m_284506143400425565gmail-"><br>
</span>I think this is too fragile to land in OE-Core. What happens if a<br>
network driver prints "device=eth0"? Or if other kernel messages make<br>
the string disappear from dmesg and connman gets restarted later?<br></blockquote><div> </div></span><div>True. If device=eth0 gets disappeared/corrupted, then we may have problem.</div><span class="gmail-"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
FWIW, I'm attaching my current wrapper script for connmand. I don't<br>
think it's perfect, but at least it doesn't depend on any init manager<br>
and works across restarts.</blockquote></span><div>The wrapper script attached by you, takes care of the missing scenarios. Seems to be more complete.</div><span class="gmail-"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"> <br></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Add these lines to connman's do_install, in case you'd like to test<br>
and/or submit it:<br>
<br>
mv ${D}${sbindir}/connmand ${D}${sbindir}/connmand.real<br>
install -m 755 ${WORKDIR}/<a href="http://connmand-nfsroot.in" rel="noreferrer" target="_blank">connmand-nfsroot.in</a> ${D}${sbindir}/connmand<br>
sed -e 's,@sbindir@,${sbindir},g' -i ${D}${sbindir}/connmand<br></blockquote></span><div>I think it would be good idea to integrate your changes into the already existing OE-core's connman script, instead of a calling original connman script from the wrapper script.</div></div></div></div></blockquote></div><br>I threw together <a href="https://github.com/openembedded/openembedded-core/compare/master...kergoth:connman-systemd-nfs">https://github.com/openembedded/openembedded-core/compare/master...kergoth:connman-systemd-nfs</a> last night, only limited testing. I think using a script in libexecdir is rather cleaner than wrapping connmand in place, for something like this, personally.<br>-- <br><div class="gmail_signature">Christopher Larson<br>clarson at kergoth dot com<br>Founder - BitBake, OpenEmbedded, OpenZaurus<br>Maintainer - Tslib<br>Senior Software Engineer, Mentor Graphics</div>
</div></div>