<div dir="ltr">Hi Andreas,<div><br></div><div>Thanks for reviewing the patch.<br><div class="gmail_extra"><br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span class="gmail-"><br>
</span>I think this is too fragile to land in OE-Core. What happens if a<br>
network driver prints &quot;device=eth0&quot;? Or if other kernel messages make<br>
the string disappear from dmesg and connman gets restarted later?<br></blockquote><div> </div><div>True. If device=eth0 gets disappeared/corrupted, then we may have problem.</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
FWIW, I&#39;m attaching my current wrapper script for connmand. I don&#39;t<br>
think it&#39;s perfect, but at least it doesn&#39;t depend on any init manager<br>
and works across restarts.</blockquote><div>The wrapper script attached by you, takes care of the missing scenarios. Seems to be more complete.</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"> <br></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Add these lines to connman&#39;s do_install, in case you&#39;d like to test<br>
and/or submit it:<br>
<br>
mv ${D}${sbindir}/connmand ${D}${sbindir}/connmand.real<br>
install -m 755 ${WORKDIR}/<a href="http://connmand-nfsroot.in" rel="noreferrer" target="_blank">connmand-nfsroot.in</a> ${D}${sbindir}/connmand<br>
sed -e &#39;s,@sbindir@,${sbindir},g&#39; -i ${D}${sbindir}/connmand<br></blockquote><div>I think it would be good idea to integrate your changes into the already existing OE-core&#39;s connman script, instead of a calling original connman script from the wrapper script.</div><div><br></div><div>Regards,</div><div>Jagadeesh</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class="gmail-HOEnZb"><div class="gmail-h5">&gt;<br>
&gt; Signed-off-by: Jagadeesh Krishnanjanappa &lt;<a href="mailto:jkrishnanjanappa@mvista.com">jkrishnanjanappa@mvista.com</a>&gt;<br>
&gt; ---<br>
&gt;  meta/recipes-connectivity/<wbr>connman/connman/connman | 35 +++++++++++++----------<br>
&gt;  1 file changed, 20 insertions(+), 15 deletions(-)<br>
&gt;<br>
&gt; diff --git a/meta/recipes-connectivity/<wbr>connman/connman/connman b/meta/recipes-connectivity/<wbr>connman/connman/connman<br>
&gt; index c64fa0d..aae2ca6 100644<br>
&gt; --- a/meta/recipes-connectivity/<wbr>connman/connman/connman<br>
&gt; +++ b/meta/recipes-connectivity/<wbr>connman/connman/connman<br>
&gt; @@ -29,23 +29,28 @@ done<br>
&gt;  do_start() {<br>
&gt;       EXTRA_PARAM=&quot;&quot;<br>
&gt;       if test $nfsroot -eq 1 ; then<br>
&gt; -         NET_DEVS=`cat /proc/net/dev | sed -ne &#39;s/^\([a-zA-Z0-9 ]*\):.*$/\1/p&#39;`<br>
&gt; -         NET_ADDR=`cat /proc/cmdline | sed -ne &#39;s/^.*ip=\([^ :]*\).*$/\1/p&#39;`<br>
&gt; +         ethn_from_dmesg=`dmesg | grep &quot;device=&quot;| sed &quot;s|\(.*\)device=\(.*\), hwaddr=\(.*\)|\2|g&quot;`<br>
&gt; +         if [ ! -z &quot;$ethn_from_dmesg&quot; ]; then<br>
&gt; +             EXTRA_PARAM=&quot;-I $ethn_from_dmesg&quot;<br>
&gt; +         else<br>
&gt; +             NET_DEVS=`cat /proc/net/dev | sed -ne &#39;s/^\([a-zA-Z0-9 ]*\):.*$/\1/p&#39;`<br>
&gt; +             NET_ADDR=`cat /proc/cmdline | sed -ne &#39;s/^.*ip=\([^ :]*\).*$/\1/p&#39;`<br>
&gt;<br>
&gt; -         if [ ! -z &quot;$NET_ADDR&quot; ]; then<br>
&gt; -             if [ &quot;$NET_ADDR&quot; = dhcp ]; then<br>
&gt; -                 ethn=`ifconfig | grep &quot;^eth&quot; | sed -e &quot;s/\(eth[0-9]\)\(.*\)/\1/&quot;`<br>
&gt; -                 if [ ! -z &quot;$ethn&quot; ]; then<br>
&gt; -                     EXTRA_PARAM=&quot;-I $ethn&quot;<br>
&gt; -                 fi<br>
&gt; -             else<br>
&gt; -                 for i in $NET_DEVS; do<br>
&gt; -                     ADDR=`ifconfig $i | sed &#39;s/addr://g&#39; | sed -ne &#39;s/^.*inet \([0-9.]*\) .*$/\1/p&#39;`<br>
&gt; -                     if [ &quot;$NET_ADDR&quot; = &quot;$ADDR&quot; ]; then<br>
&gt; -                         EXTRA_PARAM=&quot;-I $i&quot;<br>
&gt; -                         break<br>
&gt; +             if [ ! -z &quot;$NET_ADDR&quot; ]; then<br>
&gt; +                 if [ &quot;$NET_ADDR&quot; = dhcp ]; then<br>
&gt; +                     ethn=`ifconfig | grep &quot;^eth&quot; | sed -e &quot;s/\(eth[0-9]\)\(.*\)/\1/&quot;`<br>
&gt; +                     if [ ! -z &quot;$ethn&quot; ]; then<br>
&gt; +                         EXTRA_PARAM=&quot;-I $ethn&quot;<br>
&gt;                       fi<br>
&gt; -                 done<br>
&gt; +                 else<br>
&gt; +                     for i in $NET_DEVS; do<br>
&gt; +                         ADDR=`ifconfig $i | sed &#39;s/addr://g&#39; | sed -ne &#39;s/^.*inet \([0-9.]*\) .*$/\1/p&#39;`<br>
&gt; +                         if [ &quot;$NET_ADDR&quot; = &quot;$ADDR&quot; ]; then<br>
&gt; +                             EXTRA_PARAM=&quot;-I $i&quot;<br>
&gt; +                             break<br>
&gt; +                         fi<br>
&gt; +                     done<br>
&gt; +                 fi<br>
&gt;               fi<br>
&gt;           fi<br>
&gt;       fi<br>
&gt;<br>
<br>
</div></div><br>--<br>
______________________________<wbr>_________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org">Openembedded-core@lists.<wbr>openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/openembedded-<wbr>core</a><br>
<br></blockquote></div><br></div></div></div>