<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 12, 2016 at 4:21 PM, Randy MacLeod <span dir="ltr"><<a href="mailto:randy.macleod@windriver.com" target="_blank">randy.macleod@windriver.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 2016-10-08 09:17 PM, Huang, Jie (Jackie) wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
-----Original Message-----<br>
From: MacLeod, Randy<br>
Sent: Friday, October 07, 2016 4:54 AM<br>
To: Bruce Ashfield; Khem Raj; Huang, Jie (Jackie)<br>
Cc: Patches and discussions about the oe-core layer<br>
Subject: Re: [OE-core] [PATCH] linux-libc-headers: if_tunnel: remove include of if/ip/in6.h<br>
<br>
On 2016-10-03 08:27 PM, Bruce Ashfield wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
It's something we could drop in the future, but these are mods that have<br>
been done since -rc4, and could very well be undone if they start<br>
breaking things like this.<br>
<br>
The alternative is to try and fix the userspace applications, but I<br>
currently don't see a fast way to do that (and I'm now officially on<br>
vacation).<br>
<br>
</blockquote>
<br>
I've sent a fix to the net-tools list:<br>
<br>
<a href="https://sourceforge.net/p/net-tools/mailman/net-tools-devel/?viewmonth=201610" rel="noreferrer" target="_blank">https://sourceforge.net/p/net-<wbr>tools/mailman/net-tools-devel/<wbr>?viewmonth=201610</a><br>
<br>
Jackie will be back at work on Saturday and he'll revert<br>
Bruce's change, test all qemu builds and boot an image<br>
to test iptunnel before sending a patch to the list.<br>
</blockquote>
<br>
I just sent patches for this to the list.<br>
<br>
Thanks,<br>
Jackie<br>
</blockquote>
<br>
<br></span>
Jackie,<br>
<br>
Thanks for fixing the net-tools bug. A fedora dev acked the patch<br>
on the SF list so hopefully it will be integrated upstream.<br>
<br>
Bruce, Khem<br>
<br>
What, if anything, should we do about the other yocto specific changes to linux-libc-headers:<br>
<br></blockquote><div><br></div><div>Feel free to fix ppp in a similar way to the other change. It is likely a header inclusion</div><div>order change.</div><div><br></div><div>I'm just doing the kernel header changes, I can't always detangle the user space issues,</div><div>that's where others need to step in and help.</div><div><br></div><div>There's no issue in carrying it, since it isn't like we are developing software that will</div><div>be incompatible through the change, or that will have ABI issues.</div><div><br></div><div>Bruce</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
$ ls -1 meta/recipes-kernel/linux-libc<wbr>-headers/linux-libc-headers<br>
0001-libc-compat.h-fix-some-is<wbr>sues-arising-from-in6.h.patch<br>
0001-ppp-fix-in-if.h-includes.<wbr>patch<br>
0002-libc-compat.h-prevent-red<wbr>efinition-of-struct-ethhdr.pat<wbr>ch<br>
0003-remove-inclusion-of-sysin<wbr>fo.h-in-kernel.h.patch<br>
<br>
It seems like some of the patches (ppp) could be addressed and<br>
dropped and that we should do that before releasing oe-core-2.2<br>
or wait for 2.3.<br>
<br>
../Randy<br>
<br>
<br>
$ git log meta/recipes-kernel/linux-libc<wbr>-headers/linux-libc-headers/<wbr>0001-libc-compat.h-fix-some-<wbr>issues-arising-from-in6.h.<wbr>patch<br>
<br>
<br>
commit 12451a412fb7b5706c1553618ee7b7<wbr>04234876cc<br>
Author: Bruce Ashfield <<a href="mailto:bruce.ashfield@windriver.com" target="_blank">bruce.ashfield@windriver.com</a>><br>
Date: Mon Oct 3 01:54:36 2016 -0400<br>
<br>
linux-libc-headers: fix in/if.h includes<br>
<br>
The following kernel commits broke the compilation of ppp, due to redefined<br>
structures.<br>
<br>
Nothing else breaks in userspace with or without these uapi changes, so we<br>
revert them to keep everything building.<br>
<br>
commit 05ee5de7451796cf9a8aeb2f05a577<wbr>90d4fd2336<br>
Author: Mikko Rapeli <<a href="mailto:mikko.rapeli@iki.fi" target="_blank">mikko.rapeli@iki.fi</a>><br>
Date: Mon Aug 22 20:32:42 2016 +0200<br>
<br>
include/uapi/linux/if_pppol2t<wbr>p.h: include linux/in.h and linux/in6.h<br>
<br>
Fixes userspace compilation errors like:<br>
<br>
error: field <E2><80><98>addr<E2><80><99> has incomplete type<br>
struct sockaddr_in addr; /* IP address and port to send to */<br>
^<br>
error: field <E2><80><98>addr<E2><80><99> has incomplete type<br>
struct sockaddr_in6 addr; /* IP address and port to send to */<br>
<br>
Signed-off-by: Mikko Rapeli <<a href="mailto:mikko.rapeli@iki.fi" target="_blank">mikko.rapeli@iki.fi</a>><br>
Signed-off-by: David S. Miller <<a href="mailto:davem@davemloft.net" target="_blank">davem@davemloft.net</a>><div class="HOEnZb"><div class="h5"><br>
<br>
<br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
In oe-core-2.3, we should probably drop net-tools completely or<br>
at least from <a href="http://packagegroup-core-full-cmdline.bb" rel="noreferrer" target="_blank">packagegroup-core-full-cmdline<wbr>.bb</a> since iproute2<br>
replaces it:<br>
<a href="http://xmodulo.com/linux-tcpip-networking-net-tools-iproute2.html" rel="noreferrer" target="_blank">http://xmodulo.com/linux-tcpi<wbr>p-networking-net-tools-iproute<wbr>2.html</a><br>
<br>
( and I'm now officially on vacation for a few days. :) )<br>
<br>
<br>
--<br>
# Randy MacLeod. SMTS, Linux, Wind River<br>
Direct: <a href="tel:613.963.1350" value="+16139631350" target="_blank">613.963.1350</a> | 350 Terry Fox Drive, Suite 200, Ottawa, ON,<br>
Canada, K2K 2W5<br>
</blockquote>
<br>
</blockquote>
<br>
<br>
-- <br>
# Randy MacLeod. SMTS, Linux, Wind River<br>
Direct: <a href="tel:613.963.1350" value="+16139631350" target="_blank">613.963.1350</a> | 350 Terry Fox Drive, Suite 200, Ottawa, ON, Canada, K2K 2W5<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">"Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"</div>
</div></div>